http: allow _httpMessage to be GC'ed

Set `socket._httpMessage` to `null` before emitting the `'connect'` or `'upgrade'` event. PR-URL: #18865 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Apr 13, 2018 · 1edadeb · 1edadeb
1 parent d799b1c
commit 1edadeb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/_http_agent.js b/lib/_http_agent.js
@@ -249,6 +249,7 @@ function installListeners(agent, s, options) {
     s.removeListener('close', onClose);
     s.removeListener('free', onFree);
     s.removeListener('agentRemove', onRemove);
+    s._httpMessage = null;
   }
   s.on('agentRemove', onRemove);
 }

diff --git a/test/parallel/test-http-connect.js b/test/parallel/test-http-connect.js
@@ -28,7 +28,11 @@ server.listen(0, common.mustCall(() => {
     path: 'google.com:443'
   }, common.mustNotCall());
 
-  req.on('close', common.mustCall(() => {}));
+  req.on('socket', common.mustCall((socket) => {
+    assert.strictEqual(socket._httpMessage, req);
+  }));
+
+  req.on('close', common.mustCall());
 
   req.on('connect', common.mustCall((res, socket, firstBodyChunk) => {
     // Make sure this request got removed from the pool.
@@ -39,6 +43,7 @@ server.listen(0, common.mustCall(() => {
     // Make sure this socket has detached.
     assert(!socket.ondata);
     assert(!socket.onend);
+    assert.strictEqual(socket._httpMessage, null);
     assert.strictEqual(socket.listeners('connect').length, 0);
     assert.strictEqual(socket.listeners('data').length, 0);