fs,test: add URL to string to fs.watch

Signed-off-by: RafaelGSS <[email protected]> PR-URL: #51346 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Jan 5, 2024 · 22f4482 · 22f4482
1 parent 5c2b1db
commit 22f4482
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -108,7 +108,6 @@ const {
   getValidatedPath,
   getValidMode,
   handleErrorFromBinding,
-  possiblyTransformPath,
   preprocessSymlinkDestination,
   Stats,
   getStatFsFromBinding,
@@ -2451,7 +2450,7 @@ function watch(filename, options, listener) {
 
   let watcher;
   const watchers = require('internal/fs/watchers');
-  const path = possiblyTransformPath(filename);
+  const path = getValidatedPath(filename);
   // TODO(anonrig): Remove non-native watcher when/if libuv supports recursive.
   // As of November 2022, libuv does not support recursive file watch on all platforms,
   // e.g. Linux due to the limitations of inotify.

diff --git a/test/fixtures/permission/fs-read.js b/test/fixtures/permission/fs-read.js
@@ -265,6 +265,13 @@ const regularFile = __filename;
     permission: 'FileSystemRead',
     resource: path.toNamespacedPath(blockedFile),
   }));
+  assert.throws(() => {
+    fs.watch(blockedFileURL, () => {});
+  }, common.expectsError({
+    code: 'ERR_ACCESS_DENIED',
+    permission: 'FileSystemRead',
+    resource: path.toNamespacedPath(blockedFile),
+  }));
 
   // doesNotThrow
   fs.readdir(allowedFolder, (err) => {
@@ -353,4 +360,4 @@ const regularFile = __filename;
     permission: 'FileSystemRead',
     resource: path.toNamespacedPath(blockedFile),
   }));
-}
+}