fixup! report: include information about event loop itself

nodejs · Feb 5, 2019 · 2b67f5b · 2b67f5b
1 parent 307e230
commit 2b67f5b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/doc/api/report.md b/doc/api/report.md
@@ -219,7 +219,7 @@ is provided below for reference.
     {
       "type": "loop",
       "is_active": true,
-      "address": "140696384399248"
+      "address": "0x000055fc7b2cb180"
     }
   ],
   "environmentVariables": {

diff --git a/src/node_report.cc b/src/node_report.cc
@@ -319,7 +319,7 @@ static void WriteNodeReport(Isolate* isolate,
     writer.json_keyvalue("is_active",
         static_cast<bool>(uv_loop_alive(env->event_loop())));
     writer.json_keyvalue("address",
-        std::to_string(reinterpret_cast<int64_t>(env->event_loop())));
+        ValueToHexString(reinterpret_cast<int64_t>(env->event_loop())));
     writer.json_end();
   }
 

diff --git a/src/node_report.h b/src/node_report.h
@@ -57,8 +57,15 @@ void GetNodeReport(v8::Isolate* isolate,
 void ReportEndpoints(uv_handle_t* h, std::ostringstream& out);
 void WalkHandle(uv_handle_t* h, void* arg);
 std::string EscapeJsonChars(const std::string& str);
+
 template <typename T>
-std::string ValueToHexString(T value);
+std::string ValueToHexString(T value) {
+  std::stringstream hex;
+
+  hex << "0x" << std::setfill('0') << std::setw(sizeof(T) * 2) << std::hex <<
+    value;
+  return hex.str();
+}
 
 // Function declarations - export functions in src/node_report_module.cc
 void TriggerReport(const v8::FunctionCallbackInfo<v8::Value>& info);

diff --git a/src/node_report_utils.cc b/src/node_report_utils.cc
@@ -214,15 +214,6 @@ void WalkHandle(uv_handle_t* h, void* arg) {
   writer->json_end();
 }
 
-template <typename T>
-std::string ValueToHexString(T value) {
-  std::stringstream hex;
-
-  hex << "0x" << std::setfill('0') << std::setw(sizeof(T) * 2) << std::hex <<
-    value;
-  return hex.str();
-}
-
 std::string EscapeJsonChars(const std::string& str) {
   const std::string control_symbols[0x20] = {
       "\\u0000", "\\u0001", "\\u0002", "\\u0003", "\\u0004", "\\u0005",