tools: enable no-unsafe-finally

This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. PR-URL: #18745 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Feb 16, 2018 · 4d3c3f0 · 4d3c3f0
1 parent d8d84ee
commit 4d3c3f0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/.eslintrc.yaml b/.eslintrc.yaml
@@ -152,6 +152,7 @@ rules:
   }]
   no-tabs: error
   no-trailing-spaces: error
+  no-unsafe-finally: error
   object-curly-spacing: [error, always]
   one-var-declaration-per-line: error
   operator-linebreak: [error, after]

diff --git a/test/common/index.js b/test/common/index.js
@@ -504,21 +504,13 @@ exports.canCreateSymLink = function() {
     const whoamiPath = path.join(process.env['SystemRoot'],
                                  'System32', 'whoami.exe');
 
-    let err = false;
-    let output = '';
-
     try {
-      output = execSync(`${whoamiPath} /priv`, { timout: 1000 });
+      const output = execSync(`${whoamiPath} /priv`, { timout: 1000 });
+      return output.includes('SeCreateSymbolicLinkPrivilege');
     } catch (e) {
-      err = true;
-    } finally {
-      if (err || !output.includes('SeCreateSymbolicLinkPrivilege')) {
-        return false;
-      }
+      return false;
     }
   }
-
-  return true;
 };
 
 exports.getCallSite = function getCallSite(top) {