errors: alter ERR_INVALID_CURSOR_POS

Changes the base instance for ERR_INVALID_CURSOR_POS from Error to TypeError as a more accurate representation of the error. PR-URL: #19960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Apr 17, 2018 · 5135e24 · 5135e24
1 parent 77f3c1f
commit 5135e24
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -879,10 +879,8 @@ E('ERR_INVALID_BUFFER_SIZE',
   'Buffer size must be a multiple of %s', RangeError);
 E('ERR_INVALID_CALLBACK', 'Callback must be a function', TypeError);
 E('ERR_INVALID_CHAR', invalidChar, TypeError);
-
-// This should probably be a `TypeError`.
 E('ERR_INVALID_CURSOR_POS',
-  'Cannot set cursor row without setting its column', Error);
+  'Cannot set cursor row without setting its column', TypeError);
 E('ERR_INVALID_DOMAIN_NAME', 'Unable to determine the domain name', TypeError);
 E('ERR_INVALID_FD',
   '"fd" must be a positive integer: %s', RangeError);

diff --git a/test/parallel/test-readline-csi.js b/test/parallel/test-readline-csi.js
@@ -77,7 +77,7 @@ writable.data = '';
 common.expectsError(
   () => readline.cursorTo(writable, 'a', 1),
   {
-    type: Error,
+    type: TypeError,
     code: 'ERR_INVALID_CURSOR_POS',
     message: 'Cannot set cursor row without setting its column'
   });