test: replace indexOf with includes

Refs: #12586 PR-URL: #14630 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
nodejs · Aug 10, 2017 · 55aba6a · 55aba6a
1 parent 574cc37
commit 55aba6a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/test/async-hooks/init-hooks.js b/test/async-hooks/init-hooks.js
@@ -67,7 +67,7 @@ class ActivityCollector {
     const violations = [];
     function v(msg) { violations.push(msg); }
     for (const a of this._activities.values()) {
-      if (types != null && types.indexOf(a.type) < 0) continue;
+      if (types != null && !types.includes(a.type)) continue;
 
       if (a.init && a.init.length > 1) {
         v('Activity inited twice\n' + activityString(a) +
@@ -131,7 +131,7 @@ class ActivityCollector {
 
   activitiesOfTypes(types) {
     if (!Array.isArray(types)) types = [ types ];
-    return this.activities.filter((x) => types.indexOf(x.type) >= 0);
+    return this.activities.filter((x) => types.includes(x.type));
   }
 
   get activities() {

diff --git a/test/parallel/test-repl-tab-complete.js b/test/parallel/test-repl-tab-complete.js
@@ -411,7 +411,7 @@ const warningRegEx = new RegExp(
     });
 
     // no `biu`
-    assert.strictEqual(data.indexOf('ele.biu'), -1);
+    assert.strictEqual(data.includes('ele.biu'), false);
   }));
 });
-Original file line number
+Diff line change
@@ Expand Up / @@ -411,7 +411,7 @@ const warningRegEx = new RegExp( @@
         });
         // no `biu`
-        assert.strictEqual(data.indexOf('ele.biu'), -1);
+        assert.strictEqual(data.includes('ele.biu'), false);
       }));
     });
@@ Expand Down @@