test: replace indexOf with includes

Start the transition to Array.prototype.includes() and
String.prototype.includes().  This commit refactors most of the
comparisons of Array.prototype.indexOf() and String.prototype.indexOf()
return values with -1 to the former methods in tests.

Backport-PR-URL: #19447
PR-URL: #12604
Refs: #12586
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

test/addons-napi/test_constructor/test.js

@@ -22,14 +22,14 @@ const propertyNames = [];
 for (const name in test_object) {
   propertyNames.push(name);
 }
-assert.ok(propertyNames.indexOf('echo') >= 0);
-assert.ok(propertyNames.indexOf('readwriteValue') >= 0);
-assert.ok(propertyNames.indexOf('readonlyValue') >= 0);
-assert.ok(propertyNames.indexOf('hiddenValue') < 0);
-assert.ok(propertyNames.indexOf('readwriteAccessor1') < 0);
-assert.ok(propertyNames.indexOf('readwriteAccessor2') < 0);
-assert.ok(propertyNames.indexOf('readonlyAccessor1') < 0);
-assert.ok(propertyNames.indexOf('readonlyAccessor2') < 0);
+assert.ok(propertyNames.includes('echo'));
+assert.ok(propertyNames.includes('readwriteValue'));
+assert.ok(propertyNames.includes('readonlyValue'));
+assert.ok(!propertyNames.includes('hiddenValue'));
+assert.ok(!propertyNames.includes('readwriteAccessor1'));
+assert.ok(!propertyNames.includes('readwriteAccessor2'));
+assert.ok(!propertyNames.includes('readonlyAccessor1'));
+assert.ok(!propertyNames.includes('readonlyAccessor2'));
 
 // The napi_writable attribute should be ignored for accessors.
 test_object.readwriteAccessor1 = 1;

test/addons-napi/test_properties/test.js

@@ -21,14 +21,14 @@ const propertyNames = [];
 for (const name in test_object) {
   propertyNames.push(name);
 }
-assert.ok(propertyNames.indexOf('echo') >= 0);
-assert.ok(propertyNames.indexOf('readwriteValue') >= 0);
-assert.ok(propertyNames.indexOf('readonlyValue') >= 0);
-assert.ok(propertyNames.indexOf('hiddenValue') < 0);
-assert.ok(propertyNames.indexOf('readwriteAccessor1') < 0);
-assert.ok(propertyNames.indexOf('readwriteAccessor2') < 0);
-assert.ok(propertyNames.indexOf('readonlyAccessor1') < 0);
-assert.ok(propertyNames.indexOf('readonlyAccessor2') < 0);
+assert.ok(propertyNames.includes('echo'));
+assert.ok(propertyNames.includes('readwriteValue'));
+assert.ok(propertyNames.includes('readonlyValue'));
+assert.ok(!propertyNames.includes('hiddenValue'));
+assert.ok(!propertyNames.includes('readwriteAccessor1'));
+assert.ok(!propertyNames.includes('readwriteAccessor2'));
+assert.ok(!propertyNames.includes('readonlyAccessor1'));
+assert.ok(!propertyNames.includes('readonlyAccessor2'));
 
 // The napi_writable attribute should be ignored for accessors.
 test_object.readwriteAccessor1 = 1;