test: verify arguments length in common.expectsError

If `common.expectsError` is used as a callback, it will now also verify that there is only one argument (the expected error).
nodejs · Apr 26, 2018 · 6202d98 · 6202d98
1 parent 81fabe2
commit 6202d98
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/test/common/index.js b/test/common/index.js
@@ -708,6 +708,11 @@ exports.expectsError = function expectsError(fn, settings, exact) {
   }
 
   function innerFn(error) {
+    if (arguments.length !== 1) {
+      // Do not use `assert.strictEqual()` to prevent `util.inspect` from
+      // always being called.
+      assert.fail(`Expected one argument, got ${util.inspect(arguments)}`);
+    }
     const descriptor = Object.getOwnPropertyDescriptor(error, 'message');
     assert.strictEqual(descriptor.enumerable,
                        false, 'The error message should be non-enumerable');