-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: add SafeGetenv() to internal API
Allow it to be used anywhere in src/ that env variables with security implications are accessed.
- Loading branch information
1 parent
46edd94
commit 901e926
Showing
2 changed files
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
901e926
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR-URL: #11006
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Ben Noordhuis [email protected]
901e926
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw @addaleax create a git note for a situation like this, so I just tried, but it looks like they are no longer display by github :-(. https://github.com/blog/707-git-notes-display
I can see them when I added
fetch = +refs/notes/*:refs/notes/*
to my fetch refspec, but I'm not sure if that was useful.901e926
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-github huh? I don’t remember ever doing that, maybe you meant to @mention somebody else? 😄
901e926
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? :-) I was pretty sure it was you, but I also have a fabulously bad memory.
901e926
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I have literally no idea how to do that kind of thing ;) Seems like a good idea if it works, though.