lib: fix code cache generation

e7f710c broke the code cache generation since internalBinding is now passed in through the wrapper and cannot be redeclared. This patch fixes that. Refs: #21563 PR-URL: #23855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 30, 2018 · 9c0c3f1 · 9c0c3f1
1 parent b255cd4
commit 9c0c3f1
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/lib/internal/bootstrap/cache.js b/lib/internal/bootstrap/cache.js
@@ -6,8 +6,9 @@
 // cannot be tampered with even with --expose-internals
 
 const {
-  NativeModule, internalBinding
+  NativeModule
 } = require('internal/bootstrap/loaders');
+const { hasTracing } = process.binding('config');
 
 function getCodeCache(id) {
   const cached = NativeModule.getCached(id);
@@ -42,6 +43,16 @@ const cannotUseCache = [
   'internal/bootstrap/node'
 ].concat(depsModule);
 
+// Skip modules that cannot be required when they are not
+// built into the binary.
+if (process.config.variables.v8_enable_inspector !== 1) {
+  cannotUseCache.push('inspector');
+  cannotUseCache.push('internal/util/inspector');
+}
+if (!hasTracing) {
+  cannotUseCache.push('trace_events');
+}
+
 module.exports = {
   cachableBuiltins: Object.keys(NativeModule._source).filter(
     (key) => !cannotUseCache.includes(key)