errors: alter ERR_INVALID_DOMAIN_NAME

Changes the base instance for ERR_INVALID_DOMAIN_NAME from Error to TypeError as a more accurate representation of the error. PR-URL: #19961 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Apr 16, 2018 · afb4d55 · afb4d55
1 parent 12bad69
commit afb4d55
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -878,9 +878,7 @@ E('ERR_INVALID_CHAR', invalidChar, TypeError);
 // This should probably be a `TypeError`.
 E('ERR_INVALID_CURSOR_POS',
   'Cannot set cursor row without setting its column', Error);
-
-// This should probably be a `TypeError`.
-E('ERR_INVALID_DOMAIN_NAME', 'Unable to determine the domain name', Error);
+E('ERR_INVALID_DOMAIN_NAME', 'Unable to determine the domain name', TypeError);
 E('ERR_INVALID_FD',
   '"fd" must be a positive integer: %s', RangeError);
 E('ERR_INVALID_FD_TYPE', 'Unsupported fd type: %s', TypeError);

diff --git a/test/parallel/test-http-invalid-urls.js b/test/parallel/test-http-invalid-urls.js
@@ -19,7 +19,10 @@ function test(host) {
         `${module}.${fn} should not connect to ${host}`
       );
       const throws = () => { modules[module][fn](host, doNotCall); };
-      common.expectsError(throws, { code: 'ERR_INVALID_DOMAIN_NAME' });
+      common.expectsError(throws, {
+        type: TypeError,
+        code: 'ERR_INVALID_DOMAIN_NAME'
+      });
     });
   });
 }