[Squash] use function instead

nodejs · Sep 23, 2018 · bc5fd8e · bc5fd8e
1 parent 2dc37cf
commit bc5fd8e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/doc/api/http2.md b/doc/api/http2.md
@@ -411,16 +411,17 @@ added: v9.4.0
 Transmits a `GOAWAY` frame to the connected peer *without* shutting down the
 `Http2Session`.
 
-#### http2session.lastReceivedTime
+#### http2session.getLastReceivedTime()
 <!-- YAML
 added: REPLACEME
 -->
 
-* {number}
+* Returns: {number}
 
-A timestamp indicating the moment the most recently received communication of
-any kind was received from the connected peer. A value of `0` indicates that
-the session is still open but no data has yet been received.
+Returns a timestamp indicating the moment the most recently received
+communication of any kind was received from the connected peer. A value of `0`
+indicates that the session is still open but no data has yet been received.
+A value of `undefined` indicates that the session is no longer valid.
 
 #### http2session.localSettings
 <!-- YAML

diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -1015,7 +1015,7 @@ class Http2Session extends EventEmitter {
     return !!(this[kState].flags & SESSION_FLAGS_DESTROYED);
   }
 
-  get lastReceivedTime() {
+  getLastReceivedTime() {
     return !this.destroyed ? this[kHandle].getLastReceivedTime() : undefined;
   }
 

diff --git a/test/parallel/test-http2-session-lastreceivedtime.js b/test/parallel/test-http2-session-lastreceivedtime.js
@@ -15,7 +15,7 @@ const assert = require('assert');
 
 const server = createServer();
 server.on('stream', mustCall((stream) => {
-  assert(stream.session.lastReceivedTime > 0);
+  assert(stream.session.getLastReceivedTime() > 0);
   stream.respond();
   stream.end('ok');
 }));
@@ -25,7 +25,7 @@ server.listen(0, mustCall(() => {
 
   const req = client.request();
   req.on('response', mustCall(() => {
-    assert(client.lastReceivedTime > 0);
+    assert(client.getLastReceivedTime() > 0);
   }));
   req.resume();
   req.on('close', mustCall(() => {