fixup! skip strace check on asan builds

nodejs · Feb 4, 2023 · cf874a8 · cf874a8
1 parent 1216270
commit cf874a8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/.github/workflows/test-asan.yml b/.github/workflows/test-asan.yml
@@ -45,6 +45,7 @@ jobs:
       CXX: clang++
       LINK: clang++
       CONFIG_FLAGS: --enable-asan
+      ASAN: true
     steps:
       - uses: actions/checkout@v3
         with:

diff --git a/test/common/index.js b/test/common/index.js
@@ -120,6 +120,7 @@ const isFreeBSD = process.platform === 'freebsd';
 const isOpenBSD = process.platform === 'openbsd';
 const isLinux = process.platform === 'linux';
 const isOSX = process.platform === 'darwin';
+const isAsan = process.env.ASAN !== undefined;
 const isPi = (() => {
   try {
     // Normal Raspberry Pi detection is to find the `Raspberry Pi` string in
@@ -900,6 +901,7 @@ const common = {
   invalidArgTypeHelper,
   isAIX,
   isAlive,
+  isAsan,
   isDumbTerminal,
   isFreeBSD,
   isLinux,

diff --git a/test/parallel/test-strace-openat-openssl.js b/test/parallel/test-strace-openat-openssl.js
@@ -9,6 +9,8 @@ if (!common.hasCrypto)
   common.skip('missing crypto');
 if (!common.isLinux)
   common.skip('linux only');
+if (common.isAsan)
+  common.skip('strace does not work well with address sanitizer builds');
 if (spawnSync('strace').error !== undefined) {
   common.skip('missing strace');
 }