test: avoid trying to call sysctl directly

sysctl is often installed in /usr/sbin, which is not conveniently accessible to non-root. Secondly, the setting can just be read directly from the standard location and does not need to be parsed in any special fashion. PR-URL: #46366 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Jan 28, 2023 · f69e84c · f69e84c
1 parent 47cd966
commit f69e84c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/test/parallel/test-cluster-bind-privileged-port.js b/test/parallel/test-cluster-bind-privileged-port.js
@@ -24,11 +24,10 @@ const common = require('../common');
 const assert = require('assert');
 const cluster = require('cluster');
 const net = require('net');
-const { execSync } = require('child_process');
+const { readFileSync } = require('fs');
 
 if (common.isLinux) {
-  const sysctlOutput = execSync('sysctl net.ipv4.ip_unprivileged_port_start').toString();
-  const unprivilegedPortStart = parseInt(sysctlOutput.split(' ')[2], 10);
+  const unprivilegedPortStart = parseInt(readFileSync('/proc/sys/net/ipv4/ip_unprivileged_port_start'));
   if (unprivilegedPortStart <= 42) {
     common.skip('Port 42 is unprivileged');
   }