Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: misaligned node --help text #10935

Closed
mscdex opened this issue Jan 21, 2017 · 2 comments · Fixed by #10948
Closed

cli: misaligned node --help text #10935

mscdex opened this issue Jan 21, 2017 · 2 comments · Fixed by #10948
Labels
cli Issues and PRs related to the Node.js command line interface. good first issue Issues that are suitable for first-time contributors.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jan 21, 2017 •
edited
Loading

  • Version: master
  • Platform: n/a
  • Subsystem: cli

The alignment of the argument descriptions in the node --help text is off. Specifically the --inspect and --inspect-brk options do not match up. Because the full --inspect-brk argument name is the longest, all of the other arguments' descriptions may need to be indented a couple of spaces further to accommodate this longer argument name.
@mscdex mscdex added good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem. labels Jan 21, 2017
@mscdex mscdex changed the title process: misaligned node --help text cli: misaligned node --help text Jan 21, 2017
@mscdex mscdex added cli Issues and PRs related to the Node.js command line interface. and removed process Issues and PRs related to the process subsystem. labels Jan 21, 2017
@aashil
Copy link
Contributor

aashil commented Jan 21, 2017

Hi, I would like to work on this one.

@cjihrig
Copy link
Contributor

cjihrig commented Jan 21, 2017

@aashil you'll probably want to jump in here.

@aashil aashil mentioned this issue Jan 22, 2017
Merged
2 tasks
Trott pushed a commit to aashil/node that referenced this issue Jan 28, 2017
@aashil @Trott
src: fix the misalinged text on "node --help"
5d27cc1 
The alignment of the argument descriptions in the "node --help"
text is off. This commit fixes the issue by adding two spaces
before each of the argument description.

PR-URL: nodejs#10948
Fixes: nodejs#10935
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Josh Gavant <[email protected]>
joshgav pushed a commit to aashil/node that referenced this issue Feb 7, 2017
@aashil @joshgav
src: fix the misalinged text on "node --help"
3d49d3b 
The alignment of the argument descriptions in the "node --help"
text is off. This commit fixes the issue by adding two spaces
before each of the argument description.

PR-URL: nodejs#10948
Fixes: nodejs#10935
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Josh Gavant <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this issue Feb 14, 2017
@aashil @italoacasas
src: fix the misalinged text on "node --help"
e027d67 
The alignment of the argument descriptions in the "node --help"
text is off. This commit fixes the issue by adding two spaces
before each of the argument description.

PR-URL: nodejs#10948
Fixes: nodejs#10935
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Josh Gavant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: fix the misalinged text on "node --help" aashil/node
3 participants
@mscdex @cjihrig @aashil