-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading documentation in crypto.publicEncrypt and publicDecrypt #13633
Comments
seishun
added
good first issue
Issues that are suitable for first-time contributors.
and removed
good first issue
Issues that are suitable for first-time contributors.
labels
Jun 12, 2017
mscdex
added
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
labels
Jun 12, 2017
pomerantsev
added a commit
to pomerantsev/node
that referenced
this issue
Oct 6, 2017
Fixes nodejs#13633 Although, as docs mention, private keys can be used instead of public keys, I presume that these parameter explanations should be corrected.
2 tasks
MylesBorins
pushed a commit
that referenced
this issue
Oct 7, 2017
Although, as docs mention, private keys can be used instead of public keys, I presume that these parameter explanations should be corrected. Fixes: #13633 PR-URL: #16038 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Oct 11, 2017
Although, as docs mention, private keys can be used instead of public keys, I presume that these parameter explanations should be corrected. Fixes: #13633 PR-URL: #16038 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this issue
Oct 12, 2017
Although, as docs mention, private keys can be used instead of public keys, I presume that these parameter explanations should be corrected. Fixes: nodejs/node#13633 PR-URL: nodejs/node#16038 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Documentation of the crypto session of node.js is wrong. Even in public key encrypt/decrypt it talks about:
It does say later that the private key can be used instead of the public key, but still it's clearly wrong. Also it is related to #13612 in a way, that whereas if private key is submitted to this function, it can contain whitespace and/or other garble before the key. On the other hand, if a public key is submitted, the public key header must start immediately from the beginning of the string without any leading whitespace or line feeds or the operation fails.
The text was updated successfully, but these errors were encountered: