Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icu-case-mapping should not be specified; it's on by default and will go away in v8. #13688

Closed
jungshik opened this issue Jun 14, 2017 · 1 comment
Closed

icu-case-mapping should not be specified; it's on by default and will go away in v8. #13688

jungshik opened this issue Jun 14, 2017 · 1 comment
Labels
i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency.

Comments

@jungshik
Copy link

Version: output of node -v
Platform: All platform
Subsystem:

  • Version:
  • Platform:
  • Subsystem:

node.js apparently specifies 'icu-case-mapping' for v8, but it's not necessary because it's ON by default for a while.

Moreover, it's going away (see https://chromium-review.googlesource.com/c/534541/ ).

@srl295
@vsemozhetbyt vsemozhetbyt added v8 engine Issues and PRs related to the V8 dependency. i18n-api Issues and PRs related to the i18n implementation. labels Jun 14, 2017
@targos targos mentioned this issue Jun 15, 2017
Closed
@bnoordhuis bnoordhuis mentioned this issue Jun 15, 2017
Merged
@bnoordhuis
Copy link
Member

#13698

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jun 21, 2017
@bnoordhuis
src: don't set --icu_case_mapping flag on startup
1c314f5 
It's on by default now and the flag will be removed in the near future.

Fixes: nodejs#13688
PR-URL: nodejs#13698
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
addaleax pushed a commit that referenced this issue Jun 21, 2017
@bnoordhuis @addaleax
src: don't set --icu_case_mapping flag on startup
3322191 
It's on by default now and the flag will be removed in the near future.

Fixes: #13688
PR-URL: #13698
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
jungshik added a commit to jungshik/node that referenced this issue Jun 26, 2017
@jungshik
Don't add icu_case_mapping flag
c7d07a6 
It's ON by default and going away.
See https://chromium-review.googlesource.com/c/534541/ and
  nodejs#13688
@jungshik jungshik mentioned this issue Jun 26, 2017
Closed
1 task
hferreiro pushed a commit to brave/node that referenced this issue Nov 3, 2017
@bnoordhuis @hferreiro
src: don't set --icu_case_mapping flag on startup
b1a033e 
It's on by default now and the flag will be removed in the near future.

Fixes: nodejs/node#13688
PR-URL: nodejs/node#13698
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnoordhuis @jungshik @vsemozhetbyt