Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N-API: Add functions to delete properties #13924

Closed
mhdawson opened this issue Jun 26, 2017 · 2 comments
Closed

N-API: Add functions to delete properties #13924

mhdawson opened this issue Jun 26, 2017 · 2 comments
Assignees
@cjihrig
Labels
node-api Issues and PRs related to the Node-API.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jun 26, 2017 •
edited
Loading

  • Version: ALL
  • Platform: ALL
  • Subsystem: N-API

There should be NAPI functions for deleting named properties and indexed properties:

napi_status napi_delete_property(napi_env env, napi_value object, napi_propertyname name);
napi_status napi_delete_element(napi_env env, napi_value object, uint32_t i);

So far only one of the top native modules scanned (couchbase) referenced v8::Object::Delete().

The N-API team will get to this based on priorities, but this is a good place for others to contribute as well. If you start working on this, assign the issue to yourself and add a comment that you are working on it.
@mhdawson mhdawson changed the title N-API N-API: Add fundtions to delete properties Jun 26, 2017
@mscdex mscdex added the node-api Issues and PRs related to the Node-API. label Jun 26, 2017
@mhdawson mhdawson mentioned this issue Jun 26, 2017
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Jun 26, 2017

@mhdawson I'd like to work on this.

@cjihrig cjihrig self-assigned this Jun 26, 2017
@mhdawson
Copy link
Member Author

sounds good :)

@jasongin jasongin changed the title N-API: Add fundtions to delete properties N-API: Add functions to delete properties Jun 26, 2017
@mhdawson mhdawson mentioned this issue Jun 26, 2017
Closed
This was referenced Jun 26, 2017
Merged
Merged
cjihrig added a commit to cjihrig/node that referenced this issue Jun 30, 2017
@cjihrig
n-api: add napi_delete_element()
f803e77 
Refs: nodejs#13924
PR-URL: nodejs#13949
Reviewed-By: Jason Ginchereau <[email protected]>
@cjihrig cjihrig closed this as completed in 732ae41 Jul 1, 2017
addaleax pushed a commit to addaleax/node that referenced this issue Jul 3, 2017
@cjihrig @addaleax
n-api: add napi_delete_element()
aaf84ae 
Refs: nodejs#13924
PR-URL: nodejs#13949
Reviewed-By: Jason Ginchereau <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this issue Jul 3, 2017
@cjihrig @addaleax
n-api: add napi_delete_property()
8cb061a 
Fixes: nodejs#13924
PR-URL: nodejs#13934
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Ginchereau <[email protected]>
addaleax pushed a commit that referenced this issue Jul 11, 2017
@cjihrig @addaleax
n-api: add napi_delete_element()
a5c4f4e 
Refs: #13924
PR-URL: #13949
Reviewed-By: Jason Ginchereau <[email protected]>
addaleax pushed a commit that referenced this issue Jul 11, 2017
@cjihrig @addaleax
n-api: add napi_delete_property()
c30af5c 
Fixes: #13924
PR-URL: #13934
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Ginchereau <[email protected]>
addaleax pushed a commit that referenced this issue Jul 18, 2017
@cjihrig @addaleax
n-api: add napi_delete_element()
6316c9a 
Refs: #13924
PR-URL: #13949
Reviewed-By: Jason Ginchereau <[email protected]>
addaleax pushed a commit that referenced this issue Jul 18, 2017
@cjihrig @addaleax
n-api: add napi_delete_property()
820d97d 
Fixes: #13924
PR-URL: #13934
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Ginchereau <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
@cjihrig
n-api: add napi_delete_element()
ae0bdd5 
Refs: nodejs#13924
PR-URL: nodejs#13949
Reviewed-By: Jason Ginchereau <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
@cjihrig
n-api: add napi_delete_property()
22b9a87 
Fixes: nodejs#13924
PR-URL: nodejs#13934
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Ginchereau <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 16, 2018
@cjihrig @MylesBorins
n-api: add napi_delete_element()
cadec3b 
Refs: #13924
Backport-PR-URL: #19447
PR-URL: #13949
Reviewed-By: Jason Ginchereau <[email protected]>
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjihrig cjihrig

Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @cjihrig @mhdawson