test: flaky test-net-can-reset-timeout

[refack]

• Version: master
• Platform: freeBSD
• Subsystem: test,net,stream

https://ci.nodejs.org/job/node-test-commit-freebsd/10321/nodes=freebsd10-64/

not ok 820 parallel/test-net-can-reset-timeout
  ---
  duration_ms: 2.482
  severity: fail
  stack: |-
    timeout
    timeout
    server side end
    client side end
    Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
        at Object.exports.mustCall (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common/index.js:481:10)
        at Server.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-net-can-reset-timeout.js:31:31)
        at Server.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common/index.js:513:15)
        at emitOne (events.js:115:13)
        at Server.emit (events.js:210:7)
        at TCP.onconnection (net.js:1553:8)
  ...

The test:

'use strict';
const common = require('../common');
const net = require('net');

const server = net.createServer(common.mustCall(function(stream) {
  stream.setTimeout(100);

  stream.resume();

  stream.on('timeout', common.mustCall(function() {
    console.log('timeout');
    // try to reset the timeout.
    stream.write('WHAT.');
  }));

  stream.on('end', function() {
    console.log('server side end');
    stream.end();
  });
}));

server.listen(0, function() {
  const c = net.createConnection(this.address().port);

  c.on('data', function() {
    c.end();
  });

  c.on('end', function() {
    console.log('client side end');
    server.close();
  });
});

/cc @nodejs/testing @nodejs/platform-freebsd @nodejs/streams

P.S. to whomever tackles this, could you add a comment explaining what this is testing a la doc/guides/writing-tests.md

[Trott]

Unsurprisingly, this is an issue with parallelism and is not specific to FreeBSD. It is probably just showing up on FreeBSD because that is one of our more parallelized hosts for tests in CI. It's also likely surfaced due to the start-up performance hit of turning off V8 snapshots; even though this test doesn't use child_process, it's performance is likely impacted by more resources being required by other tests starting up and possibly starting sub-processes in parallel.

Here is partial output of a reproduction on macOS:

$ tools/test.py -j 92 --repeat 920 test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===                    
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
    at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
    at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
    at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===                    
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
    at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
    at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
    at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===                    
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
    at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
    at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
    at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===                    
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
    at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
    at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
    at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===                    
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
    at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
    at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
    at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===                    
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
    at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
    at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
    at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===                    
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
    at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
    at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
    at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js

[Trott]

Problem occurs if the timeout fires more than once which can happen on a heavily loaded host. The test ought to permit timeout firing multiple times. It was written for nodejs/node-v0.x-archive#481.

[Trott]

Fix coming in a few minutes.

[Trott]

Fix is in #14257.