Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate test-timers-blocking-callback #14792

Closed
aqrln opened this issue Aug 12, 2017 · 2 comments
Closed

Investigate test-timers-blocking-callback #14792

aqrln opened this issue Aug 12, 2017 · 2 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. windows Issues and PRs related to the Windows platform.

Comments

@aqrln
Copy link
Contributor

aqrln commented Aug 12, 2017

Unrelated failure of sequential/test-timers-blocking-callback on win2008r2 in #14773:

not ok 438 sequential/test-timers-blocking-callback
  ---
  duration_ms: 2.877
  severity: fail
  stack: |-
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: false == true
        at blockingCallback (c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vs2015\label\win2008r2\test\sequential\test-timers-blocking-callback.js:51:5)
        at ontimeout (timers.js:469:11)
        at tryOnTimeout (timers.js:304:5)
        at Timer.listOnTimeout (timers.js:264:5)
  ...

https://ci.nodejs.org/job/node-test-binary-windows/10459/RUN_SUBSET=1,VS_VERSION=vs2015,label=win2008r2/console

/cc @nodejs/testing @nodejs/platform-windows
@aqrln aqrln added flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. windows Issues and PRs related to the Windows platform. labels Aug 12, 2017
@misterdjules
Copy link

test-timers-blocking-callback is unfortunately inherently flaky. See #9198 (comment) for a previous discussion on this topic.

Trott added a commit to Trott/io.js that referenced this issue Aug 14, 2017
@Trott
test: make timers-blocking-callback more reliable
83208ab 
test-timers-blocking-callback may fail erroneously on
resource-constrained machines due to the timing nature of the test.

There is likely no way around the timing issue. This change tries to
decrease the probability of the test failing erroneously by having it
retry a small number of times on failure.

Tested on 0.10.38 (which has a bug that this test was written for) and
(modifying the test slightly to remove ES6 stuff) the test still seems
to fail 100% of the time there, which is what we want/expect.

Fixes: nodejs#14792
@Trott Trott mentioned this issue Aug 14, 2017
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Aug 14, 2017

Attempted mitigation: #14831

@Trott Trott closed this as completed in c473d80 Aug 20, 2017
MylesBorins pushed a commit that referenced this issue Sep 10, 2017
@Trott @MylesBorins
test: make timers-blocking-callback more reliable
118d662 
test-timers-blocking-callback may fail erroneously on
resource-constrained machines due to the timing nature of the test.

There is likely no way around the timing issue. This change tries to
decrease the probability of the test failing erroneously by having it
retry a small number of times on failure.

Tested on 0.10.38 (which has a bug that this test was written for) and
(modifying the test slightly to remove ES6 stuff) the test still seems
to fail 100% of the time there, which is what we want/expect.

PR-URL: #14831
Fixes: #14792
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 12, 2017
@Trott @MylesBorins
test: make timers-blocking-callback more reliable
c0312dc 
test-timers-blocking-callback may fail erroneously on
resource-constrained machines due to the timing nature of the test.

There is likely no way around the timing issue. This change tries to
decrease the probability of the test failing erroneously by having it
retry a small number of times on failure.

Tested on 0.10.38 (which has a bug that this test was written for) and
(modifying the test slightly to remove ES6 stuff) the test still seems
to fail 100% of the time there, which is what we want/expect.

PR-URL: #14831
Fixes: #14792
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 20, 2017
@Trott @MylesBorins
test: make timers-blocking-callback more reliable
7245082 
test-timers-blocking-callback may fail erroneously on
resource-constrained machines due to the timing nature of the test.

There is likely no way around the timing issue. This change tries to
decrease the probability of the test failing erroneously by having it
retry a small number of times on failure.

Tested on 0.10.38 (which has a bug that this test was written for) and
(modifying the test slightly to remove ES6 stuff) the test still seems
to fail 100% of the time there, which is what we want/expect.

PR-URL: #14831
Fixes: #14792
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: make timers-blocking-callback more reliable Trott/io.js
3 participants
@Trott @misterdjules @aqrln