Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Allow 'cwd' in cluster.settings #16388

Closed
laino opened this issue Oct 22, 2017 · 0 comments
Closed

Feature request: Allow 'cwd' in cluster.settings #16388

laino opened this issue Oct 22, 2017 · 0 comments
Labels
cluster Issues and PRs related to the cluster subsystem. feature request Issues that request new features to be added to Node.js.

Comments

@laino
Copy link

laino commented Oct 22, 2017

  • Subsystem: cluster

cwd is the only property currently missing from cluster.settings, but which is available in child_process.fork().

It should however only be added after #16387 is resolved, to avoid encouraging people to rush face first into that bug.

The actual implementation would just be cwd: cluster.settings.cwd, added here.
@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. feature request Issues that request new features to be added to Node.js. labels Oct 23, 2017
@cjihrig cjihrig mentioned this issue Jan 26, 2018
Merged
4 tasks
cjihrig added a commit to cjihrig/node that referenced this issue Jan 29, 2018
@cjihrig
cluster: add cwd to cluster.settings
e0864e5 
This commit allows cluster workers to be created with
configurable working directories.

Fixes: nodejs#16388
PR-URL: nodejs#18399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
evanlucas pushed a commit that referenced this issue Jan 30, 2018
@cjihrig @evanlucas
cluster: add cwd to cluster.settings
799fd24 
This commit allows cluster workers to be created with
configurable working directories.

Fixes: #16388
PR-URL: #18399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@cjihrig @MayaLekova
cluster: add cwd to cluster.settings
fa93931 
This commit allows cluster workers to be created with
configurable working directories.

Fixes: nodejs#16388
PR-URL: nodejs#18399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this issue Aug 2, 2018
@cjihrig @MylesBorins
cluster: add cwd to cluster.settings
47ac3cf 
This commit allows cluster workers to be created with
configurable working directories.

Fixes: #16388
PR-URL: #18399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this issue Aug 2, 2018
@cjihrig @MylesBorins
cluster: add cwd to cluster.settings
d4ae6ad 
This commit allows cluster workers to be created with
configurable working directories.

Fixes: #16388
PR-URL: #18399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this issue Aug 16, 2018
@cjihrig @rvagg
cluster: add cwd to cluster.settings
dc000a5 
This commit allows cluster workers to be created with
configurable working directories.

Fixes: #16388
PR-URL: #18399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @laino