Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8::debug::GetDebugContext is going away. #18643

Closed
hashseed opened this issue Feb 8, 2018 · 2 comments
Closed

v8::debug::GetDebugContext is going away. #18643

hashseed opened this issue Feb 8, 2018 · 2 comments
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@hashseed
Copy link
Member

hashseed commented Feb 8, 2018

If I remember correctly we agreed on delaying the removal of GetDebugContext until Node 9. I would like to remove the API and more importantly the legacy code backing it. That means that Node cannot use it anymore though. It currently still does.

Given the success of the DevTools protocol I think we can remove it. Can we advance this somehow so that by Node 10 it's not exposed to add-ons anymore?
@hashseed
Copy link
Member Author

hashseed commented Feb 8, 2018

/cc @ofrobots

@bnoordhuis bnoordhuis added the v8 engine Issues and PRs related to the V8 dependency. label Feb 8, 2018
@bnoordhuis
Copy link
Member

I removed the last vestiges in core in November, see #13295. Node 10 won't be using it.

I'm okay with making it inaccessible to add-ons (in node 10); otherwise it might hold us back trying to upgrade V8 mid-cycle.

hashseed added a commit to hashseed/node that referenced this issue Feb 9, 2018
@hashseed
build: no longer have v8-debug.h as dependency.
d3fe812 
Ref: nodejs#18643
@hashseed hashseed mentioned this issue Feb 9, 2018
Merged
2 tasks
hashseed added a commit to hashseed/node that referenced this issue Feb 9, 2018
@hashseed
build: no longer have v8-debug.h as dependency.
8b91ef3 
Ref: nodejs#18643
@hashseed hashseed mentioned this issue Feb 9, 2018
Closed
2 tasks
BridgeAR pushed a commit to BridgeAR/node that referenced this issue Feb 10, 2018
@hashseed @BridgeAR
build: no longer have v8-debug.h as dependency.
4a1a4bf 
Ref: nodejs#18643

PR-URL: nodejs#18677
Refs: nodejs#18643
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@hashseed @MylesBorins
build: no longer have v8-debug.h as dependency.
a53067c 
Ref: #18643

PR-URL: #18677
Refs: #18643
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@hashseed @MylesBorins
build: no longer have v8-debug.h as dependency.
4eb31cf 
Ref: #18643

PR-URL: #18677
Refs: #18643
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@hashseed @MylesBorins
build: no longer have v8-debug.h as dependency.
d2f7468 
Ref: #18643

PR-URL: #18677
Refs: #18643
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@hashseed @MylesBorins
build: no longer have v8-debug.h as dependency.
080368b 
Ref: #18643

PR-URL: #18677
Refs: #18643
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 13, 2018
@hashseed @MylesBorins
build: no longer have v8-debug.h as dependency.
88d3028 
Ref: #18643

PR-URL: #18677
Refs: #18643
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@hashseed @MayaLekova
build: no longer have v8-debug.h as dependency.
5ba4a09 
Ref: nodejs#18643

PR-URL: nodejs#18677
Refs: nodejs#18643
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnoordhuis @hashseed