Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: outdated link #20853

Closed
vsemozhetbyt opened this issue May 20, 2018 · 7 comments
Closed

doc: outdated link #20853

vsemozhetbyt opened this issue May 20, 2018 · 7 comments
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors. macos Issues and PRs related to the macOS platform / OSX.

Comments

@vsemozhetbyt
Copy link
Contributor

https://nodejs.org/api/fs.html#fs_availability section contains FSEvents link which is currently redirected to a page that seems unrelated.

@nodejs/platform-macos, can you check and fix or suggest a new link?
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX. labels May 20, 2018
@LEQADA
Copy link

LEQADA commented May 20, 2018

Probably this link is related?
https://developer.apple.com/documentation/coreservices/file_system_events

@ryzokuken
Copy link
Contributor

I tried searching the lot, but the link suggested by @LEQADA is the best I could find.

Apparently, the guide was removed or something. The link above also mentions the guide, but it seems to get redirected.

@shobhitchittora
Copy link
Contributor

@vsemozhetbyt Should we then update the link or notify concerned teams about the non-functioning link.

@vsemozhetbyt
Copy link
Contributor Author

@nodejs/platform-macos, can we replace the outdated link with the suggested one?

@ryzokuken
Copy link
Contributor

ryzokuken commented May 24, 2018 •
edited
Loading

@vsemozhetbyt we should, I think.

Let's make this into a good-first-issue?

@vsemozhetbyt vsemozhetbyt added the good first issue Issues that are suitable for first-time contributors. label May 24, 2018
@amitbend
Copy link
Contributor

Is it ok that I'll take it?

@vsemozhetbyt
Copy link
Contributor Author

@amitbend Feel free to open a PR)

@amitbend amitbend mentioned this issue May 24, 2018
Closed
4 tasks
targos pushed a commit that referenced this issue May 25, 2018
@amitbend @targos
doc: fix outdated link FSEvents
c036cda 
PR-URL: #20949
Fixes: #20853
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shobhitchittora @LEQADA @vsemozhetbyt @amitbend @ryzokuken