Inconsistent documentation: hostname vs host #20892
Comments
apapirovski
added
help wanted
apapirovski
changed the title
|
@nodejs/documentation @nodejs/http @nodejs/http2 |
|
Definitely 👍 . I think this would be a good source of tasks for a code&learn. |
|
I agree, this is a source of confusion for myself. This ASCII Chart does a good job of explaining the difference. I even found a Chrome Bug after reading through the Node.js docs regarding All that to say, I agree with this change 👍 |
|
Interested in picking this up... |
|
@davisokoth let me know if you need any guidance. There are a few links in the OP to documentation mistakes but it would be nice to also update some of the variable names in our code. Feel free to also open a PR just with one of those documentation changes — we don't have to change everything all at once. |
|
Also interested in contributing to this |
Update reference to read `hostname` instead of `host` for consistency. Fixes nodejs#20892 partially Also update function signature to use `hostname` rather than `host`
Update reference to read `hostname` instead of `host` for consistency. Also update function signature to use `hostname` rather than `host` PR-URL: #20933 Refs: #20892 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Also interested in contributing to this if help is still needed |
|
I am also interested in contributing... |
Update reference to read `hostname` instead of `host` for consistency. Also update function signature to use `hostname` rather than `host` PR-URL: nodejs#20933 Refs: nodejs#20892 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
@apapirovski anything left to be done or can you please point other issue to work on? |
|
I'm working on |
Update reference to read `hostname` instead of `host` for consistency. Also update function signature to use `hostname` rather than `host` PR-URL: #20933 Refs: #20892 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: #21172
Update reference to read `hostname` instead of `host` for consistency. Also update function signature to use `hostname` rather than `host` PR-URL: #20933 Refs: #20892 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: #21172
|
I'm interested in getting involved in this project. Thanks guys. |
|
@thatshailesh @sagirk @graezzon There's definitely more to be done. Some of the links in the OP haven't been updated and there are likely more instances of this in the codebase. Just look for any irregularities of hostname vs host usage, in particular cases where the term is used interchangeably to refer to the same thing. |
|
@apapirovski I ran a project-wide search and found a few instances of this issue in
|
|
@benjipelletier @lliepert @UlisesGascon @thatshailesh @graezzon Take a look at one of the files listed above and claim it in this thread so we know who is working on what. |
|
Thanks @sagirk! I am working now in |
|
Hi All |
Updated error messages and function arguments Refs: nodejs#20892
|
Hi guys, I'm late to join. I'm interested to contribute as well. Can I get started. Are there any open tasks to pick up? |
Fixes: #20892 PR-URL: #23572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #20892 PR-URL: #23572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #20892 PR-URL: #23572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #20892 PR-URL: #23572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
The Node.js documentation is currently rather freeform when it comes to distinguishing between
hostnameandhost. There are arguments and properties namedhostthat refer tohostnameand their description makes as much clear. There are also arguments and properties that refer tohostin both the name and the description, despite actually intending to represent thehostname.This can without any doubt create confusion for end users but also for contributors. For a recent example see: #20875 or #20493
I think it would be nice if we could slowly update the the documentation and code to be more clear about this. While we cannot change property names on options objects, argument names can certainly be changed and documentation can be updated.
Some example entries:
https://nodejs.org/dist/latest-v10.x/docs/api/tls.html#tls_tls_checkserveridentity_host_cert
https://nodejs.org/dist/latest-v10.x/docs/api/tls.html#tls_tls_connect_port_host_options_callback
https://nodejs.org/dist/latest-v10.x/docs/api/tls.html#tls_tls_connect_options_callback
https://nodejs.org/dist/latest-v10.x/docs/api/net.html#net_server_listen_options_callback
The text was updated successfully, but these errors were encountered: