Remove message parameter from strictEqual() #20911
Comments
sagirk
added a commit
to sagirk/node
that referenced
this issue
May 23, 2018
In test/parallel/test-require-process.js, the last thing in the test is a call to assert.strictEqual(). It has a string literal as its third argument. Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError. That's not helpful for debugging. This is fixed by removing the third argument from the call. It is, however, preserved in a comment above the call to assert.strictEqual(). Fixes: nodejs#20911 Refs: https://www.nodetodo.org/getting-started
4 tasks
targos
pushed a commit
that referenced
this issue
May 25, 2018
In test/parallel/test-require-process.js, the last thing in the test is a call to assert.strictEqual(). It has a string literal as its third argument. Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError. That's not helpful for debugging. This is fixed by removing the third argument from the call. It is, however, preserved in a comment above the call to assert.strictEqual(). PR-URL: #20912 Fixes: #20911 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
sagirk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Got this
good first issueto work on, courtesy Node Todo.Problem
Take a look at test/parallel/test-require-process.js.
The last thing in the test is a call to
assert.strictEqual(). It has a string literal as its third argument.Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError.
That's not helpful for debugging.
Solution
Remove the third argument from the call and make it a comment above the call to assert.strictEqual().
🙏 Thanks a ton @Trott for guidance! Looking forward to get my first contribution landed into Node.js core.
The text was updated successfully, but these errors were encountered: