Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console coverage missing #20952

Closed
BridgeAR opened this issue May 24, 2018 · 7 comments
Closed

Console coverage missing #20952

BridgeAR opened this issue May 24, 2018 · 7 comments
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.

Comments

@BridgeAR
Copy link
Member

I just wanted to check the coverage of the console module but it seems like it is missing. I am not sure if this is an issue on our side or on module side. I did not yet look into it.
@BridgeAR BridgeAR added meta Issues and PRs related to the general management of the project. build Issues and PRs related to build files or the CI. labels May 24, 2018
@BridgeAR
Copy link
Member Author

@nodejs/build @bcoe PTAL

@bcoe
Copy link
Contributor

bcoe commented May 28, 2018

@BridgeAR I'm happy to take a look at why we're not seeing coverage for the console module.

@maclover7
Copy link
Contributor

@BridgeAR @bcoe This CI job may be helpful, runs coverage everyday: https://ci.nodejs.org/view/All/job/node-test-commit-linux-coverage/

@bcoe
Copy link
Contributor

bcoe commented May 30, 2018

@BridgeAR I've hunted things down to here and have a workaround we can apply:

babel/babel#8075

I'm going to see about getting things fixed upstream first.

@bcoe bcoe mentioned this issue May 31, 2018
Merged
bcoe pushed a commit to bcoe/node-1 that referenced this issue Jun 1, 2018
build: fail on instrumentation errors
09011f0 
nyc was silently failing to instrument new language features,
resulting in a failure to instrument console.js.

Refs: nodejs#20952
@bcoe bcoe mentioned this issue Jun 1, 2018
Closed
2 tasks
bcoe pushed a commit that referenced this issue Jun 25, 2018
build: fail on instrumentation errors
ba4f5e9 
nyc was silently failing to instrument new language features,
resulting in a failure to instrument console.js.

Refs: #20952
PR-URL: #21071
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rebecca Turner <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@bcoe
Copy link
Contributor

bcoe commented Jun 25, 2018

@BridgeAR I think this issue should be fixed now, with some upstream changes to nyc; mind checking.

targos pushed a commit that referenced this issue Jun 26, 2018
@targos
build: fail on instrumentation errors
2250631 
nyc was silently failing to instrument new language features,
resulting in a failure to instrument console.js.

Refs: #20952
PR-URL: #21071
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rebecca Turner <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@bcoe
Copy link
Contributor

bcoe commented Jul 3, 2018

@BridgeAR https://coverage.nodejs.org/coverage-f85962fe4d3afa55/root/console.js.html 👈 object to me closing this, things are looking good.

@bcoe bcoe closed this as completed Jul 10, 2018
@BridgeAR
Copy link
Member Author

@bcoe thanks a lot for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcoe @maclover7 @BridgeAR