Investigate flaky sequential/test-inspector-break-when-eval

[Trott]

• Version: v11.0.0-pre (master)
• Platform: win10 vs2017
• Subsystem: test inspector

https://ci.nodejs.org/job/node-test-binary-windows/18435/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=2/console

03:46:08 not ok 568 sequential/test-inspector-break-when-eval
03:46:08   ---
03:46:08   duration_ms: 0.426
03:46:08   severity: fail
03:46:08   exitcode: 1
03:46:08   stack: |-
03:46:08     [test] Connecting to a child Node process
03:46:08     [test] Testing /json/list
03:46:08     [err] Debugger listening on ws://127.0.0.1:63764/ce7a415f-e235-4e76-9b07-378faa517c97
03:46:08     [err] For help, see: https://nodejs.org/en/docs/inspector
03:46:08     [err] 
03:46:08     [out] Ready!
03:46:08     [out] 
03:46:08     [test] Setting up a debugger
03:46:08     [test] Breaking in the code
03:46:08     [test] Step over console statement and test output
03:46:08     [out] 0 3
03:46:08     [out] 
03:46:08     [test] Verify node waits for the frontend to disconnect
03:46:08     [err] Debugger attached.
03:46:08     [err] Waiting for the debugger to disconnect...
03:46:08     [err] 
03:46:08     { AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
03:46:08     + expected - actual
03:46:08     
03:46:08     - 0
03:46:08     + 3221225477
03:46:08         at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-break-when-eval.js:65:10)
03:46:08         at process._tickCallback (internal/process/next_tick.js:68:7)
03:46:08       generatedMessage: true,
03:46:08       name: 'AssertionError [ERR_ASSERTION]',
03:46:08       code: 'ERR_ASSERTION',
03:46:08       actual: 0,
03:46:08       expected: 3221225477,
03:46:08       operator: 'strictEqual' }
03:46:08     1
03:46:08   ...

@nodejs/testing @nodejs/platform-windows @nodejs/v8-inspector @nodejs/build

[addaleax]

Side note: #21182 is a large-ish refactor of some of the inspector code, so it might make sense to re-check all flaky inspector tests after that?

[eugeneo]

Still failing with that change, but the failure is different. I will make sure that change fixes it.

[eugeneo]

https://ci.nodejs.org/job/node-stress-single-test/nodes=win10-vs2017/1952/ - 1000 runs, no failures. I am hoping to land #21182 by the end of the week.