-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process.stdin.setRawMode(true) does not return process.stdin? #22916
Comments
FWIW, these signatures are documented differently: https://nodejs.org/api/tty.html#tty_readstream_setrawmode_mode And Lines 69 to 73 in bb9d788
|
yeah it should right, why not. Shouldn't break anybody to return |
@ORESoftware Yes, I think this would be okay to add – do you want to open a PR maybe? |
sure I can do that, I would also want to update the TypeScript typings for this |
I don't think we maintain those but the actual change seems fine to me. |
PR-URL: #22950 Fixes: #22916 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
I have this:
but I cannot use it like so:
just curious if that is true and why that is. It could just be that the TypeScript typings are wrong.
Anyway, I would expect that
process.stdin.setRawMode()
would return the same thing asprocess.stdin.setEncoding()
.The text was updated successfully, but these errors were encountered: