Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test runner fails slow tests even though they pass #25867

Closed
hashseed opened this issue Feb 1, 2019 · 2 comments
Closed

Test runner fails slow tests even though they pass #25867

hashseed opened this issue Feb 1, 2019 · 2 comments

Comments

@hashseed
Copy link
Member

hashseed commented Feb 1, 2019

img

The reason seems to be that test-callback-error is listed in test/root.status to be SLOW in debug mode. When it turns out to run well enough, it is considered to fail. That's a bit surprising.
@richardlau
Copy link
Member

Being addressed in #25698.

@hashseed hashseed mentioned this issue Feb 1, 2019
Closed
2 tasks
refack pushed a commit that referenced this issue Feb 4, 2019
@hashseed @refack
test: do not fail SLOW tests if they are not slow
dfe5f8f 
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
addaleax pushed a commit that referenced this issue Feb 6, 2019
@hashseed @addaleax
test: do not fail SLOW tests if they are not slow
025a7c3 
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@richardlau
Copy link
Member

Fixed by dfe5f8f.

BethGriggs pushed a commit that referenced this issue Dec 4, 2019
@hashseed @BethGriggs
test: do not fail SLOW tests if they are not slow
fabbc76 
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
MylesBorins pushed a commit that referenced this issue Dec 17, 2019
@hashseed @MylesBorins
test: do not fail SLOW tests if they are not slow
7e941eb 
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hashseed @richardlau