-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The binary and long term compatibility with node #43
Comments
Initial releases, 100%, but being that we have no control over where Joyent will take their fork in the future we can't really commit to staying compatible with whatever they decide to do. If there is a divergence we might choose to deprecate the "node" binary which is one reason I think it's important to install the iojs binary as well. |
I think that absent a +1 on being able to defer the decision on deprecating |
FFmpeg was forked into LibAV, LibAV used the same FFmpeg binary names without any issue, at the end LibAV diverged a lot from FFmpeg removing bunchs of functionalities and then they stopped using ffmpeg binary name but people already migrated their scripts to libav if they actually used libav. I think that was the right approach on the long-term and short-term. (The example is based on the fact that FFmpeg may be even bigger than node and it worked). Other thing, I remember the name node is already used by other binary from the ham-community (reason why node is Debian-based systems is usually called |
@ghostbar thanks for that story, it's incredibly relevant and puts to ease some of the concerns we've had. |
The've also diverged, but are still |
Another thing that'll come up is the |
@klaemo’s point is important. And my 2¢: it should be |
see #46 |
IMO |
fwiw, I just went through the |
Good idea @kenperkins, interesting experiment. |
@kenperkins that's because it uses the alternatives from Debian-based distros, where you can have it called the same way and link to It's the same way with generic names like |
There are already at least two programming languages named io, and any two-character name should be considered a no-go. I would be interested in hearing arguments in favor of "io" over "iojs" for the binary name, but I feel like I need convincing. |
I don't think |
+1 for |
👍 For |
people that really care will |
|
Noting the discussion here (re: the project's default command line name) may relate to the outcome of #118 |
Per today's TC meeting, the plan is to rename to binary to |
@bnoordhuis so that means that if node is already present, we won't do anything (wrt to the symlink, or removing node)? I'm not sure I like the idea that depending on the state of the system, invoking I wonder if we'd be better off being more explicit in our behavior; a couple of options:
Thoughts? |
NAN requires executing 'node' to find the location of the header. Windows compatibility is the main source of problems when it comes to using multiple alternative names. nodejs/nan#70 |
@kenperkins After thinking about it some more, I fear that stomping on an existing install is probably the only workable approach. I didn't realize how much stuff the installer installs into $prefix/include and $prefix/lib and I don't think it's possible to detect whether that's from a joyent/node or iojs install. |
Having |
Original commit message: Merged: Squashed multiple commits. Merged: [const-tracking] Mark const field as mutable when reconfiguring Revision: 7535b91f7cb22274de734d5da7d0324d8653d626 Merged: [const-tracking] Fix incorrect DCHECK in MapUpdater Revision: f95db8916a731e6e5ccc0282616bc907ce06012f BUG=chromium:1161847,chromium:1185463,v8:9233 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=[email protected] (cherry picked from commit 56518020bff4d0e8b82cff843c9f618c90084e42) Change-Id: I7f46a701646e1dd67a049b2aa4ac32d05b6885f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748079 Commit-Queue: Georg Neis <[email protected]> Reviewed-by: Igor Sheludko <[email protected]> Cr-Original-Commit-Position: refs/branch-heads/8.9@{nodejs#43} Cr-Original-Branched-From: 16b9bbbd581c25391981aa03180b76aa60463a3e-refs/heads/8.9.255@{#1} Cr-Original-Branched-From: d16a2a688498bd1c3e6a49edb25d8c4ca56232dc-refs/heads/master@{#72039} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794428 Reviewed-by: Victor-Gabriel Savu <[email protected]> Commit-Queue: Artem Sumaneev <[email protected]> Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#73} Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472} Refs: v8/v8@ffde6ee
There has been a bit of discussion in #28 about what to name the binary. This probably deserves it's own discussion.
The proposed approach
presents some additional questions:
The text was updated successfully, but these errors were encountered: