Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last nightly and canary binaries for Windows have no proper application icon #45025

Closed
vsemozhetbyt opened this issue Oct 16, 2022 · 2 comments · Fixed by #45042
Closed

Last nightly and canary binaries for Windows have no proper application icon #45025

vsemozhetbyt opened this issue Oct 16, 2022 · 2 comments · Fixed by #45042
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 16, 2022 •
edited
Loading

Version

Last nightly and canary binaries

Platform

Windows 10

What steps will reproduce the bug?

Here are the last release vs the last nightly and canary binaries:

Node1

Here is the last canary after installation:

Node2

The change have happened between v19.0.0-nightly20220717 and v19.0.0-nightly20220718:

Node3

What do you see instead?

No icons in downloaded or installed binaries.
@targos
Copy link
Member

targos commented Oct 17, 2022

Diff between these versions: dabda03...0e660ce

I suspect aa3a572

@targos targos added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Oct 17, 2022
@richardlau richardlau mentioned this issue Oct 17, 2022
Merged
@richardlau
Copy link
Member

I suspect aa3a572

Yes, it looks like this removed the Windows resource file from the list of sources. Opened #45042 to add it back.

nodejs-github-bot pushed a commit that referenced this issue Oct 19, 2022
@richardlau
build: restore Windows resource file
eb298df 
Add back the Windows resource file to the build scripts that was
mistakenly removed by aa3a572.

PR-URL: #45042
Fixes: #45025
Refs: #43652
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 1, 2022
@richardlau @RafaelGSS
build: restore Windows resource file
65d04cc 
Add back the Windows resource file to the build scripts that was
mistakenly removed by aa3a572.

PR-URL: #45042
Fixes: #45025
Refs: #43652
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 10, 2022
@richardlau @RafaelGSS
build: restore Windows resource file
17349a2 
Add back the Windows resource file to the build scripts that was
mistakenly removed by aa3a572.

PR-URL: #45042
Fixes: #45025
Refs: #43652
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: restore Windows resource file richardlau/node-1
3 participants
@targos @richardlau @vsemozhetbyt