Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERR_INTERNAL_ASSERTION in internalConnectMultiple #48763

Closed
hp8wvvvgnj6asjm7 opened this issue Jul 14, 2023 · 8 comments · Fixed by #51045
Closed

ERR_INTERNAL_ASSERTION in internalConnectMultiple #48763

hp8wvvvgnj6asjm7 opened this issue Jul 14, 2023 · 8 comments · Fixed by #51045
Labels
confirmed-bug Issues with confirmed bugs. net Issues and PRs related to the net subsystem.

Comments

@hp8wvvvgnj6asjm7
Copy link

hp8wvvvgnj6asjm7 commented Jul 14, 2023 •
edited
Loading

Version

v20.4.0

Platform

Microsoft Windows NT 10.0.19044.0 x64

Subsystem

No response

What steps will reproduce the bug?

I'm running a worker thread(s) which runs an openWebsocket and passes messages to the main thread via postmessage.
I don't get any messages and after a few minutes, I get this error:

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

Error: This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
Please open an issue with this stack trace at https://github.com/nodejs/node/issues

    at new NodeError (node:internal/errors:405:5)
    at assert (node:internal/assert:14:11)
    at internalConnectMultiple (node:net:1115:3)
    at Timeout.internalConnectMultipleTimeout (node:net:1683:3)
    at listOnTimeout (node:internal/timers:575:11)
    at processTimers (node:internal/timers:514:7) {
  code: 'ERR_INTERNAL_ASSERTION'
}
Trace:
    at error (C:\Users\_\Desktop\sys\core.ts:3963:25)
    at Worker.<anonymous> (C:\Users\_\Desktop\sys\core.ts:3894:95)
    at Worker.emit (node:events:512:28)
    at Worker.[kOnErrorMessage] (node:internal/worker:326:10)
    at Worker.[kOnMessage] (node:internal/worker:337:37)
    at MessagePort.<anonymous> (node:internal/worker:232:57)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:778:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)

Additional information

No response
@debadree25
Copy link
Member

Could you provide any sample code to reproduce? preferably without any dependencies!

@tniessen
Copy link
Member

Possibly related to #47644? It might not be a duplicate because #47644 was allegedly fixed (more than once). cc @ShogunPanda

@bnoordhuis bnoordhuis mentioned this issue Jul 15, 2023
Closed
@ShogunPanda
Copy link
Contributor

I can't really do anything without at least a repro code. Will standby this.

@dmcr dmcr mentioned this issue Aug 4, 2023
Closed
@tniessen
Copy link
Member

According to @Rand0mF's #47644 (comment), this also happens without using worker threads or web sockets.

@ShogunPanda
Copy link
Contributor

ShogunPanda commented Sep 11, 2023 •
edited
Loading

If the bug is related to my changes (which most likely is), it's unrelated to either worker threads or websocket as we're talking about a bug in the connection handling. But I need the exact scenario to reproduce it, unfortunately.

@tniessen tniessen mentioned this issue Oct 26, 2023
Closed
@tniessen
Copy link
Member

@hp8wvvvgnj6asjm7 Has the issue been resolved?

@tniessen tniessen added the net Issues and PRs related to the net subsystem. label Nov 22, 2023
@hp8wvvvgnj6asjm7
Copy link
Author

@hp8wvvvgnj6asjm7 Has the issue been resolved?

no, but I can't make a small reproducible example and its so random that it's hard to tell what is going on.

This was referenced Dec 2, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@tniessen tniessen changed the title ERR_INTERNAL_ASSERTION with workers and websockets ERR_INTERNAL_ASSERTION in internalConnectMultiple Dec 2, 2023
@tniessen tniessen added the confirmed-bug Issues with confirmed bugs. label Dec 2, 2023
@ShogunPanda ShogunPanda mentioned this issue Dec 4, 2023
Merged
@marco-ippolito marco-ippolito mentioned this issue Dec 16, 2023
Closed
nodejs-github-bot pushed a commit that referenced this issue Dec 21, 2023
@ShogunPanda
net: add connection attempt events
2cb9424 
PR-URL: #51045
Fixes: #48763
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@ShogunPanda
Copy link
Contributor

This should have been fixed in #51045. Once it gets in 21.x or 20.x please let me know if you have additional problems.

RafaelGSS pushed a commit that referenced this issue Jan 2, 2024
@ShogunPanda @RafaelGSS
net: add connection attempt events
e4be5b6 
PR-URL: #51045
Fixes: #48763
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
joshlarson added a commit to mbta/skate that referenced this issue Feb 14, 2024
@joshlarson
fix: Upgrade node to 21.6.0
64b427f 
This fixes an issue where running individual tests sometimes fails
with this error:

node:internal/assert:14 throw new ERR_INTERNAL_ASSERTION(message);

More info here: nodejs/node#48763
And here: nodejs/node#50383
@joshlarson joshlarson mentioned this issue Feb 14, 2024
Merged
joshlarson added a commit to mbta/skate that referenced this issue Feb 15, 2024
@joshlarson
fix: Upgrade node to 20.11.1
7470718 
This fixes an issue where running individual tests sometimes fails
with this error:

node:internal/assert:14 throw new ERR_INTERNAL_ASSERTION(message);

More info here: nodejs/node#48763
And here: nodejs/node#50383
joshlarson added a commit to mbta/skate that referenced this issue Feb 15, 2024
@joshlarson
fix: Upgrade node to 20.11.1
6ee0eab 
This fixes an issue where running individual tests sometimes fails
with this error:

node:internal/assert:14 throw new ERR_INTERNAL_ASSERTION(message);

More info here: nodejs/node#48763
And here: nodejs/node#50383
joshlarson added a commit to mbta/skate that referenced this issue Feb 15, 2024
@joshlarson
fix: Upgrade node to 20.11.0
0eb30eb 
This fixes an issue where running individual tests sometimes fails
with this error:

node:internal/assert:14 throw new ERR_INTERNAL_ASSERTION(message);

More info here: nodejs/node#48763
And here: nodejs/node#50383
joshlarson added a commit to mbta/skate that referenced this issue Feb 15, 2024
@joshlarson
chore/fix: Upgrade node to 20.11.0
9896916 
This fixes an issue where running individual tests sometimes fails
with this error:

node:internal/assert:14 throw new ERR_INTERNAL_ASSERTION(message);

More info here: nodejs/node#48763
And here: nodejs/node#50383
joshlarson added a commit to mbta/skate that referenced this issue Feb 15, 2024
@joshlarson
chore/fix: Upgrade node to 20.11.0
081bfda 
This fixes an issue where running individual tests sometimes fails
with this error:

node:internal/assert:14 throw new ERR_INTERNAL_ASSERTION(message);

More info here: nodejs/node#48763
And here: nodejs/node#50383
joshlarson added a commit to mbta/skate that referenced this issue Feb 21, 2024
@joshlarson
chore/fix: Upgrade node to 20.11.0 (#2398)
63c5999 
This fixes an issue where running individual tests sometimes fails
with this error:

node:internal/assert:14 throw new ERR_INTERNAL_ASSERTION(message);

More info here: nodejs/node#48763
And here: nodejs/node#50383
richardlau pushed a commit that referenced this issue Mar 25, 2024
@ShogunPanda @richardlau
net: add connection attempt events
58a636b 
PR-URL: #51045
Fixes: #48763
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net: add new connection attempts events ShogunPanda/node
4 participants
@ShogunPanda @tniessen @debadree25 @hp8wvvvgnj6asjm7