Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation misleads embedders #7129

Closed
Silur opened this issue Jun 3, 2016 · 3 comments
Closed

Documentation misleads embedders #7129

Silur opened this issue Jun 3, 2016 · 3 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@Silur
Copy link

Silur commented Jun 3, 2016

The most recent documentations still claim that one can make nodeJS addons in C: Node.js Addons are dynamically-linked shared objects, written in C or C++
However currently there is no official way for this to happen using pure C, only wrapper-hacking and thirdparty tools. Either stop lying in the docs or provide a source where one don't have to use namaspaces and C++-only data types to write a node extension.

@bnoordhuis
Copy link
Member

Documentation pull requests welcome!

@Silur
Copy link
Author

Silur commented Jun 3, 2016

I've created one: #7130

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Jun 3, 2016
BethGriggs added a commit to BethGriggs/node that referenced this issue May 11, 2017
@gibfahn gibfahn reopened this May 11, 2017
@gibfahn
Copy link
Member

gibfahn commented May 11, 2017

Reopened as it'll be closed by #12898 when it lands

anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
PR-URL: nodejs#12898
Fixes: nodejs#7129
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
PR-URL: nodejs#12898
Fixes: nodejs#7129
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 16, 2018
Backport-PR-URL: #19447
PR-URL: #12898
Fixes: #7129
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants