Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix setTimeout, remove unused err #10193

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/parallel/test-domain-uncaught-exception.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function test1() {
d.run(function() {
setTimeout(function onTimeout() {
throw new Error('boom!');
});
}, 1);
});
}

Expand Down Expand Up @@ -59,7 +59,7 @@ function test3() {
const d3 = domain.create();
const d4 = domain.create();

d3.on('error', function onErrorInD3Domain(err) {
d3.on('error', function onErrorInD3Domain() {
process.send('errorHandledByDomain');
});

Expand Down Expand Up @@ -88,15 +88,15 @@ function test4() {
const d5 = domain.create();
const d6 = domain.create();

d5.on('error', function onErrorInD2Domain(err) {
d5.on('error', function onErrorInD2Domain() {
process.send('errorHandledByDomain');
});

d5.run(function() {
d6.run(function() {
setTimeout(function onTimeout() {
throw new Error('boom!');
});
}, 1);
});
});
}
Expand All @@ -115,7 +115,7 @@ function test5() {
const d7 = domain.create();
const d8 = domain.create();

d8.on('error', function onErrorInD3Domain(err) {
d8.on('error', function onErrorInD3Domain() {
process.send('errorHandledByDomain');
});

Expand All @@ -139,15 +139,15 @@ function test6() {
const d9 = domain.create();
const d10 = domain.create();

d10.on('error', function onErrorInD2Domain(err) {
d10.on('error', function onErrorInD2Domain() {
process.send('errorHandledByDomain');
});

d9.run(function() {
d10.run(function() {
setTimeout(function onTimeout() {
throw new Error('boom!');
});
}, 1);
});
});
}
Expand Down