Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.x backport - doc: correct vcbuild options for windows testing #10686

Closed
wants to merge 1 commit into from
Closed

v7.x backport - doc: correct vcbuild options for windows testing #10686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ Prerequisites:
To run the tests:

```console
> .\vcbuild test
> .\vcbuild nosign test
```

To test if Node.js was built correctly:
Expand Down Expand Up @@ -179,7 +179,7 @@ $ ./configure --with-intl=full-icu --download=all
##### Windows:

```console
> .\vcbuild full-icu download-all
> .\vcbuild nosign full-icu download-all
```

#### Building without Intl support
Expand All @@ -196,7 +196,7 @@ $ ./configure --without-intl
##### Windows:

```console
> .\vcbuild without-intl
> .\vcbuild nosign without-intl
```

#### Use existing installed ICU (Unix / OS X only):
Expand Down Expand Up @@ -239,7 +239,7 @@ First unpack latest ICU to `deps/icu`
as `deps/icu` (You'll have: `deps/icu/source/...`)

```console
> .\vcbuild full-icu
> .\vcbuild nosign full-icu
```

## Building Node.js with FIPS-compliant OpenSSL
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,19 +167,19 @@ $ ./configure && make -j4 test
Windows:

```text
> vcbuild test
.\vcbuild nosign test
```

(See the [BUILDING.md](./BUILDING.md) for more details.)

Make sure the linter is happy and that all tests pass. Please, do not submit
patches that fail either check.

Running `make test`/`vcbuild test` will run the linter as well unless one or
Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
more tests fail.

If you want to run the linter without running tests, use
`make lint`/`vcbuild jslint`.
`make lint`/`.\vcbuild nosign jslint`.

If you are updating tests and just want to run a single test to check it, you
can use this syntax to run it exactly as the test harness would:
Expand Down