-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: make process.env work with symbols for in/delete #11709
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getter for process.env already allows symbols to be used, and `in` operator as a read-only operator can do the same. `delete a[b]` operator in ES always returns `true` without doing anything when `b in a === false`. Allow symbols in the deleter accordingly.
TimothyGu
added
c++
Issues and PRs that require attention from people who are familiar with C++.
process
Issues and PRs related to the process subsystem.
labels
Mar 6, 2017
nodejs-github-bot
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
Mar 6, 2017
mscdex
added
the
semver-major
PRs that contain breaking changes and should be released in the next major version.
label
Mar 6, 2017
bnoordhuis
approved these changes
Mar 6, 2017
addaleax
approved these changes
Mar 6, 2017
cjihrig
approved these changes
Mar 6, 2017
jasnell
approved these changes
Mar 6, 2017
Removed semver-major since the change is backwards-compatible (it only allows more cases than it did before). Plus, the PR that made it necessary is only in master (#9446), not in any release staging branches. |
TimothyGu
removed
the
semver-major
PRs that contain breaking changes and should be released in the next major version.
label
Mar 7, 2017
@mscdex Just making sure, you are okay with my taking off semver-major right? If there are no more objections I'll land this tomorrow. |
Landed in e2f151f |
TimothyGu
added a commit
that referenced
this pull request
Mar 10, 2017
The getter for process.env already allows symbols to be used, and `in` operator as a read-only operator can do the same. `delete a[b]` operator in ES always returns `true` without doing anything when `b in a === false`. Allow symbols in the deleter accordingly. PR-URL: #11709 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
The getter for process.env already allows symbols to be used, and `in` operator as a read-only operator can do the same. `delete a[b]` operator in ES always returns `true` without doing anything when `b in a === false`. Allow symbols in the deleter accordingly. PR-URL: nodejs#11709 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getter for process.env already allows symbols to be used, and
in
operator as a read-only operator can do the same.delete a[b]
operator in ES always returnstrue
without doing anything whenb in a === false
. Allow symbols in the deleter accordingly.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
process