Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.x backport - test: convert var->const/let in tests #11775

Closed
wants to merge 5 commits into from
Closed

v6.x backport - test: convert var->const/let in tests #11775

wants to merge 5 commits into from

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Mar 9, 2017 •
edited
Loading

I'll fix up the commit messages once the tests are passing. EDIT: They are.

Backport of #10685, I couldn't cherry-pick as it brought in hundreds of unrelated changes, so I redid the eslint --fix and manual fixup for v6.x.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, tools

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Mar 9, 2017
@gibfahn
Copy link
Member Author

gibfahn commented Mar 9, 2017

CI: https://ci.nodejs.org/job/node-test-commit/8347/

Once CI is passing I'll squash and tidy up. @MylesBorins

@gibfahn
Copy link
Member Author

gibfahn commented Mar 10, 2017 •
edited
Loading

CI was green, squashing and rerunning.

If anyone wants to review, var2const-v6.x-presquash has the pre-squash commits (the most recent 4 commits are the ones that were manual).

CI 2: https://ci.nodejs.org/job/node-test-commit/8358/

Should be good to land if CI passes.

@gibfahn gibfahn changed the title WIP - v6.x backport - test: convert var->const/let in tests v6.x backport - test: convert var->const/let in tests Mar 10, 2017
@gibfahn
Copy link
Member Author

gibfahn commented Mar 10, 2017

CI failure looks like an Jenkins/Git issue, rerunning to confirm:

CI 3: https://ci.nodejs.org/job/node-test-commit/8373/

@sam-github sam-github changed the title v6.x backport - test: convert var->const/let in tests 6.x backport - test: convert var->const/let in tests Mar 10, 2017
@sam-github sam-github changed the title 6.x backport - test: convert var->const/let in tests v6.x backport - test: convert var->const/let in tests Mar 10, 2017
@gibfahn gibfahn mentioned this pull request Mar 11, 2017
Closed
4 tasks
@cjihrig cjihrig mentioned this pull request Mar 11, 2017
Merged
2 tasks
@jasnell
Copy link
Member

jasnell commented Mar 16, 2017

largely rubber stamp LGTM assuming CI is all good

@aqrln aqrln mentioned this pull request Mar 21, 2017
Closed
2 tasks
sam-github and others added 3 commits March 21, 2017 22:26
@sam-github @MylesBorins
deps: upgrade zlib to 1.2.11
8383742 
PR-URL: nodejs#10980
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@mhdawson @jasnell
doc: add supported platforms list
74a7a1d 
Original Commit Message:
  PR-URL: nodejs#11872
  Reviewed-By: James M Snell <[email protected]>
  Reviewed-By: Rich Trott <[email protected]>
  Reviewed-By: Roman Reiss <[email protected]>
  Reviewed-By: Ben Noordhuis <[email protected]>
  Reviewed-By: Gibson Fahnestock <[email protected]>

Backport-Of: nodejs#11872
PR-URL: nodejs#11943
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mhdawson @jasnell
doc: add supported platforms list for v6.x
6803521 
PR-URL: nodejs#11943
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 22, 2017

This needs a rebase on the current v6.x-staging

gibfahn and others added 2 commits March 22, 2017 17:54
@gibfahn
test: use eslint to fix var->const/let
19ce5f6 
Manually fix issues that eslint --fix couldn't do automatically.
@gibfahn
tools, test: require const/let in test
cb0904d
@gibfahn
Copy link
Member Author

gibfahn commented Mar 22, 2017

This needs a rebase on the current v6.x-staging

Done

MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
@gibfahn @MylesBorins
tools, test: require const/let in test
daddf5a 
Backport-PR-URL: #11775
PR-URL: #10685
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
@gibfahn @MylesBorins
test: use eslint to fix var->const/let
b2fc0f0 
Manually fix issues that eslint --fix couldn't do automatically.

Backport-PR-URL: #11775
PR-URL: #10685
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 078188d...b2fc0f0

@gibfahn gibfahn deleted the var2const-v6.x branch April 14, 2017 08:09
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@gibfahn @MylesBorins
tools, test: require const/let in test
de63698 
Backport-PR-URL: #11775
PR-URL: #10685
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@gibfahn @MylesBorins
test: use eslint to fix var->const/let
db61c95 
Manually fix issues that eslint --fix couldn't do automatically.

Backport-PR-URL: #11775
PR-URL: #10685
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@gibfahn @andrew749
tools, test: require const/let in test
6aea35d 
Backport-PR-URL: nodejs/node#11775
PR-URL: nodejs/node#10685
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@gibfahn @andrew749
test: use eslint to fix var->const/let
cd87208 
Manually fix issues that eslint --fix couldn't do automatically.

Backport-PR-URL: nodejs/node#11775
PR-URL: nodejs/node#10685
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@sam-github sam-github sam-github approved these changes

Assignees

@jasnell jasnell

@MylesBorins MylesBorins

Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gibfahn @jasnell @MylesBorins @sam-github @TimothyGu @nodejs-github-bot @mhdawson