test: improve test coverage for n-api #12327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic tests for handle scopes as code coverage reports that we are not covering these with the existing tests.
jasnell
approved these changes
Apr 11, 2017
cjihrig
approved these changes
Apr 11, 2017
| const assert = require('assert'); | ||
|
|
||
| // testing handle scope api calls | ||
| const test_handle_scope = |
There was a problem hiding this comment.
Can you use camelCase in the JS code.
There was a problem hiding this comment.
sure just copied other existing test as a base, but that's not a good reason :). Updating
|
Pushed commit to address switch to camel case in js. |
|
Landed as 0ec0272 |
mhdawson
added a commit
that referenced
this pull request
Apr 12, 2017
Add basic tests for handle scopes as code coverage reports that we are not covering these with the existing tests. PR-URL: #12327 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Add basic tests for handle scopes as code coverage reports that we are not covering these with the existing tests. PR-URL: nodejs#12327 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Add basic tests for handle scopes as code coverage reports that we are not covering these with the existing tests. Backport-PR-URL: #19447 PR-URL: #12327 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, n-api