Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: get rid of dead code #12398

Closed
wants to merge 1 commit into from
Closed

n-api: get rid of dead code #12398

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

remove code that is no longer used after
n-api: create napi_env as a real structure
#12195

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]
Affected core subsystem(s)

n-api

@mhdawson
n-api: get rid of dead code
4d55bd3 
remove code that is no longer used after
  n-api: create napi_env as a real structure
  nodejs#12195
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Apr 13, 2017
addaleax
addaleax approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw #12366 would catch this as well – but feel free to land this as a trivial change ahead of it if you like.

@mhdawson
Copy link
Member Author

I don't think this is needed anymore since #12366 landed

@mhdawson mhdawson closed this Apr 18, 2017
@mhdawson mhdawson deleted the napi-dead1 branch June 28, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongin jasongin jasongin approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@digitalinfinity digitalinfinity digitalinfinity approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhdawson @digitalinfinity @addaleax @cjihrig @jasongin @nodejs-github-bot