-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add initial documentation for N-API #12549
Closed
+3,019
−0
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
68ea642
doc: Add initial documentation for N-API
mhdawson 049c9b6
squash: address first set of comments
mhdawson 67c7191
squash: address more comments
mhdawson f4417ef
squash: address next set of comments
mhdawson d32ce36
squash: e ->env where appropriate
mhdawson 250bbe1
squash: update initial references to functions in Exceptions
mhdawson 65e5865
squash: replace references to functions with links - Object lifetime
mhdawson f1b2a4d
squash: remove sub headings for API function sections
mhdawson cb616df
squash: misc cleanup
mhdawson 2e4f2fd
squash: more cleanup
mhdawson e00bae1
squash: add in when added metadata
mhdawson 13aeecd
squash: make references to functions links in Async section
mhdawson 942a250
squash: one more cleanup pass
mhdawson 017ed87
squash: add information about truncation of 32 bit ints
mhdawson a60ce7c
squash: address new linter failures
mhdawson 0ec57fd
squash: remove double spaces in [in/out]
mhdawson eaea6c0
squash: remove low level headers in struct definitions
mhdawson a9702e7
squash: Make parameter descriptions use regular grammar
mhdawson 5bb5431
squash: fix problems visible in html version of docs
mhdawson 3332195
squash: address additional comment
mhdawson 6a461c0
squash: fix up formating of structure member definitions
mhdawson 0225b29
squash: address latest comments
mhdawson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should include the
Experimental
stability index flag here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we have that in the actual section on n-api but I can add here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having it in both places is good.