Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use mustCall() in test-readline-interface #13259

Closed
wants to merge 1 commit into from
Closed

test: use mustCall() in test-readline-interface #13259

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 27, 2017

Use common.mustCall() to make sure noop function is called as
expected.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test readline

@Trott
test: use mustCall() in test-readline-interface
06b77d8 
Use `common.mustCall()` to make sure noop function is called as
expected.
@Trott Trott added readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests. labels May 27, 2017
@Trott
Copy link
Member Author

Trott commented May 31, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8381/

Trott added a commit to Trott/io.js that referenced this pull request May 31, 2017
@Trott
test: use mustCall() in test-readline-interface
3686778 
Use `common.mustCall()` to make sure noop function is called as
expected.

PR-URL: nodejs#13259
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 31, 2017

Landed in 3686778

@Trott Trott closed this May 31, 2017
jasnell pushed a commit that referenced this pull request Jun 5, 2017
@Trott @jasnell
test: use mustCall() in test-readline-interface
9df8e2a 
Use `common.mustCall()` to make sure noop function is called as
expected.

PR-URL: #13259
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request Jun 5, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@Trott @MylesBorins
test: use mustCall() in test-readline-interface
7919eee 
Use `common.mustCall()` to make sure noop function is called as
expected.

PR-URL: #13259
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott @MylesBorins
test: use mustCall() in test-readline-interface
371b648 
Use `common.mustCall()` to make sure noop function is called as
expected.

PR-URL: #13259
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the mustCallreadline branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @refack @jasnell @lpinca @cjihrig @richardlau @MylesBorins