Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 5.9.211.37 #13631

Closed
wants to merge 1 commit into from
Closed

deps: update V8 to 5.9.211.37 #13631

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 12, 2017

Update to current 5.9-lkgr

@nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jun 12, 2017
@targos targos mentioned this pull request Jun 12, 2017
Closed
2 tasks
@targos
Copy link
Member Author

targos commented Jun 15, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8674/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/743/

@jasnell
Copy link
Member

jasnell commented Jun 15, 2017

Rubber stamp LGTM

@rvagg
Copy link
Member

rvagg commented Jun 15, 2017

I missed that 5.9 was merged, but going back through the issues I'm not seeing that we have microbenchmark results for the impact of this upgrade. Has anyone done this?

@rvagg
Copy link
Member

rvagg commented Jun 15, 2017

@nodejs/v8 ^^ re benchmarks. I know we have https://benchmarking.nodejs.org/ but has anyone run the benchmarks in source to show the difference?

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 15, 2017 •
edited
Loading

@rvagg FWIW, there are rather old results in #11851

@rvagg
Copy link
Member

rvagg commented Jun 15, 2017

@vsemozhetbyt that's why I'm interested now, because those results are not promising in the whole

@targos
Copy link
Member Author

targos commented Jun 19, 2017 •
edited
Loading

Ping @nodejs/v8

Edit: wait, I will update to patch 37.
Edit 2: updated to 5.9.211.37

@targos targos changed the title deps: update V8 to 5.9.211.35 deps: update V8 to 5.9.211.37 Jun 19, 2017
@targos
Copy link
Member Author

targos commented Jun 19, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/8732/
New arm run: https://ci.nodejs.org/job/node-test-commit-arm/10424/
New windows-fanned run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/9883/

@targos targos mentioned this pull request Jun 19, 2017
Closed
2 tasks
@rvagg rvagg mentioned this pull request Jun 19, 2017
Merged
@targos
Copy link
Member Author

targos commented Jun 20, 2017

Landed in 8f907b6

@targos targos closed this Jun 20, 2017
@targos targos deleted the update-v8-59 branch June 20, 2017 08:53
targos added a commit that referenced this pull request Jun 20, 2017
@targos
deps: update V8 to 5.9.211.37
8f907b6 
PR-URL: #13631
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack
Copy link
Contributor

refack commented Jun 20, 2017

CITGM on master for good measure: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/881/

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @jasnell @rvagg @vsemozhetbyt @refack @bnoordhuis @nodejs-github-bot