Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,lib,test,doc: correct misspellings #13719

Closed
wants to merge 1 commit into from
Closed

src,lib,test,doc: correct misspellings #13719

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src, lib, test, doc

Fixed a number of misspellings all over the code base as identified by misspell. The only relevant code change in this commit is on src/tracing/trace_event.h.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. debugger i18n-api Issues and PRs related to the i18n implementation. node-api Issues and PRs related to the Node-API. net Issues and PRs related to the net subsystem. tools Issues and PRs related to the tools directory. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. windows Issues and PRs related to the Windows platform. labels Jun 16, 2017
addaleax
addaleax approved these changes Jun 16, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I’m not sure we should touch the commit lists in the changelogs (I know we have done that for e.g. Markdown problems, but these probably should match the commit messages as they appear in git?)

@silverwind
Copy link
Contributor Author

I’m not sure we should touch the commit lists in the changelogs

I pondered there too, but ultimately I just see them as docs and the commit hash still correctly identifies the commits.

@mscdex
Copy link
Contributor

mscdex commented Jun 16, 2017

Yes, in the past we've left the commit messages alone in the changelog, at least as far as spelling corrections go. I also agree with that.

@mscdex mscdex added lib / src Issues and PRs related to general changes in the lib or src directory. and removed c++ Issues and PRs that require attention from people who are familiar with C++. debugger i18n-api Issues and PRs related to the i18n implementation. node-api Issues and PRs related to the Node-API. net Issues and PRs related to the net subsystem. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. windows Issues and PRs related to the Windows platform. labels Jun 16, 2017
@silverwind
Copy link
Contributor Author

silverwind commented Jun 16, 2017 •
edited
Loading

Removed the changes in doc/changelogs.

@silverwind
Copy link
Contributor Author

Landed in ecf6a46.

@silverwind silverwind closed this Jun 17, 2017
@silverwind silverwind deleted the spelling branch June 17, 2017 17:19
silverwind added a commit that referenced this pull request Jun 17, 2017
@silverwind
src,lib,test,doc: correct misspellings
ecf6a46 
PR-URL: #13719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 18, 2017
@silverwind @addaleax
src,lib,test,doc: correct misspellings
3e3e910 
PR-URL: #13719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 20, 2017
@silverwind @addaleax
src,lib,test,doc: correct misspellings
1c03721 
PR-URL: #13719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@silverwind @addaleax
src,lib,test,doc: correct misspellings
608c4e4 
PR-URL: #13719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 24, 2017
@silverwind @addaleax
src,lib,test,doc: correct misspellings
fab7d5d 
PR-URL: #13719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 29, 2017
@silverwind @rvagg
src,lib,test,doc: correct misspellings
2439be0 
PR-URL: #13719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@silverwind @addaleax
src,lib,test,doc: correct misspellings
b733d60 
PR-URL: #13719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@silverwind @addaleax
src,lib,test,doc: correct misspellings
864abc5 
PR-URL: #13719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

@silverwind
Copy link
Contributor Author

Probably not worth to backport, there are no behavorial changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. lib / src Issues and PRs related to general changes in the lib or src directory. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@silverwind @mscdex @MylesBorins @addaleax @lpinca @cjihrig @gibfahn @nodejs-github-bot