dgram: change parameter name in set(Multicast)TTL #13747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the parameter name in set(Multicast)TTL from "arg" to "ttl" both within code and error messages.
tniessen
added
dgram
nodejs-github-bot
added
the
dgram
lpinca
reviewed
Jun 18, 2017
lib/dgram.js
Outdated
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE', | ||
| 'arg', | ||
| 'ttl', | ||
| 'number'); |
There was a problem hiding this comment.
What do you think about adding the actual argument?
lpinca
approved these changes
Jun 18, 2017
|
No, once the error has been migrated to using the error code, changes to the message should no longer be considered semver-major. Only changes to the code or error type would be. |
jasnell
approved these changes
Jun 19, 2017
jasnell
removed
the
semver-major
tniessen
added a commit
that referenced
this pull request
Jun 20, 2017
Changed the parameter name in set(Multicast)TTL from "arg" to "ttl" both within code and error messages and added the actual type of the argument to the error message. PR-URL: #13747 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 279fcc4. CI on master: https://ci.nodejs.org/job/node-test-commit/10690/ |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
Changed the parameter name in set(Multicast)TTL from "arg" to "ttl" both within code and error messages and added the actual type of the argument to the error message. PR-URL: #13747 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
|
Should this be backported to v6.x? |
|
ping @tniessen |
|
@MylesBorins Sorry, must have missed the notification. No, this should not be backported to v6.x as it uses the new errors API and an adaption to the old error system would make it semver-major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the parameter name in set(Multicast)TTL from "arg" to "ttl" both within code and error messages. The documentation already contains the correct parameter name.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
dgram
For consideration of the @nodejs/ctc due to being semver-major.