Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: clean up config_fips.gypi #13837

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: clean up config_fips.gypi
Currently when configuring the project using --openssl-fips a gyp
include file name config_fips.gypi will be created. If the project is
later configured but without the --openssl-fips flag an error will
occur. For example:

  $ ./configure --openssl-fips=bogus
  $ ./configure && make -j8
  ...
  /node/deps/openssl/fips/fipsld:
  line 8: /bin/fipsld: No such file or directory
  Error 127

This commit suggests removing the generate config_fips.gypi when the
--openssl-fips flag is not give on the command line.
  • Loading branch information
danbev committed Jun 21, 2017
commit 24f9419a5bbcb345d00a39bc66c25ecd304d8e86
1 change: 1 addition & 0 deletions configure
Original file line number Diff line number Diff line change
@@ -984,6 +984,7 @@ def configure_openssl(o):
]
else:
o['variables']['openssl_fips'] = ''
os.remove('config_fips.gypi')


if options.without_ssl: