Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move crypto_bio/clienthello to crypto ns #13957

Closed
wants to merge 1 commit into from
Closed

src: move crypto_bio/clienthello to crypto ns #13957

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 28, 2017

Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, crypto

@danbev
src: move crypto_bio/clienthello to crypto ns
fcc2030 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. tls Issues and PRs related to the tls subsystem. labels Jun 28, 2017
@danbev
Copy link
Contributor Author

danbev commented Jun 28, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8847/

refack
refack approved these changes Jun 28, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@refack
Copy link
Contributor

refack commented Jun 28, 2017 •
edited
Loading

Just to make sure, does this affect the C++ API/ABI in any way?

@danbev
Copy link
Contributor Author

danbev commented Jun 28, 2017

Just to make sure, does this affect the C++ API/ABI in any way?

I think it does. For example if we look at the symbols in node_crypto_bio.o before:

...
0000000000001cc0 s __ZZN4node7NodeBIO9FreeEmptyEvE4args_0
...

And compare them with the symbols after this patch:

...
0000000000001d10 s __ZZN4node6crypto7NodeBIO9FreeEmptyEvE4args_0
...

bnoordhuis
bnoordhuis approved these changes Jun 28, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apropos ABI: they're all inside #if defined(NODE_WANT_INTERNALS) guards so they're not public.

@danbev
Copy link
Contributor Author

danbev commented Jun 29, 2017

Apropos ABI: they're all inside #if defined(NODE_WANT_INTERNALS) guards so they're not public.

@refack I was wrong regarding the ABI. @bnoordhuis Thanks.

danbev added a commit to danbev/node that referenced this pull request Jun 30, 2017
@danbev
src: move crypto_bio/clienthello to crypto ns
08109a3 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

PR-URL: nodejs#13957
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented Jun 30, 2017

Landed in 08109a3

@danbev danbev closed this Jun 30, 2017
@danbev danbev deleted the move-to-crypto-namespace branch June 30, 2017 05:35
addaleax pushed a commit that referenced this pull request Jun 30, 2017
@danbev @addaleax
src: move crypto_bio/clienthello to crypto ns
5c34efc 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

PR-URL: #13957
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jun 30, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 30, 2017
@danbev @addaleax
src: move crypto_bio/clienthello to crypto ns
ff71987 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

PR-URL: #13957
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@danbev @addaleax
src: move crypto_bio/clienthello to crypto ns
dde3bf9 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

PR-URL: #13957
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@danbev @addaleax
src: move crypto_bio/clienthello to crypto ns
ef67f7c 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

PR-URL: #13957
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@danbev @MylesBorins
src: move crypto_bio/clienthello to crypto ns
401f3ce 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

PR-URL: #13957
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
@danbev @MylesBorins
src: move crypto_bio/clienthello to crypto ns
375c274 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

PR-URL: #13957
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@danbev @MylesBorins
src: move crypto_bio/clienthello to crypto ns
51364b7 
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.

PR-URL: #13957
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Sep 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @refack @bnoordhuis @jasnell @cjihrig @MylesBorins @nodejs-github-bot