test: add test for http outgoing internal headers #13980
Conversation
|
|
||
| const outHeadersKey = require('internal/http').outHeadersKey; | ||
| const http = require('http'); | ||
| const OutgoingMessage = http.OutgoingMessage; |
There was a problem hiding this comment.
Perhaps just:
const { OutgoingMessage } = require('http');
|
The first word after the This can be fixed by whoever lands the pull request, but if you do it for them, it will save them a few keystrokes. See commit message guidelines at https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines. (You probably saw them and were trying to follow them but there's a lot of stuff there so it's easy to miss a small thing here or there.) |
gergelyke
changed the title
|
is there anything else I should fix? |
|
@nodejs/testing @nodejs/http |
|
should be fixed @cjihrig |
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| const outHeadersKey = require('internal/http').outHeadersKey; |
There was a problem hiding this comment.
For consistency...
const { outHeadersKey } = require('internal/http');
| host: ['host', 'risingstack.com'], | ||
| origin: ['Origin', 'localhost'] | ||
| }); | ||
| } |
There was a problem hiding this comment.
lint: file needs to end with \n
|
Looks like this needs a |
|
should be all fixed :) |
|
@refack is it me who should fi things, or the CI has some issues? |
@gergelyke CI had issues. AFAICT the jobs that did finish were green. |
PR-URL: nodejs#13980 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Landed in f406a7e |
|
Extra sanity test on |
PR-URL: #13980 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #13980 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http