test: refactor test-http-invalidheaderfield #13996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide
Trott
added
http
cjihrig
approved these changes
Jun 30, 2017
jasnell
approved these changes
Jun 30, 2017
lpinca
approved these changes
Jun 30, 2017
|
Landed in 9955c30 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 3, 2017
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide PR-URL: nodejs#13996 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 3, 2017
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide PR-URL: nodejs#13996 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide PR-URL: #13996 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide PR-URL: #13996 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide PR-URL: #13996 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 15, 2017
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide PR-URL: #13996 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 15, 2017
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide PR-URL: #13996 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
* use common.mustNotCall() to confirm callback is not invoked * whitespace change per test-writing guide PR-URL: #13996 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
This was referenced Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test http