Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: split up cpplint to avoid long cmd lines #14116

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -432,12 +432,16 @@ goto cpplint

:cpplint
if not defined cpplint goto jslint
echo running cpplint
call :run-cpplint src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h
call :run-python tools/check-imports.py
goto jslint

:run-cpplint
if "%*"=="" goto exit
echo running cpplint '%*'
set cppfilelist=
setlocal enabledelayedexpansion
for /f "tokens=*" %%G in ('dir /b /s /a src\*.c src\*.cc src\*.h ^
test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h ^
test\gc\binding.cc tools\icu\*.cc tools\icu\*.h') do (
for /f "tokens=*" %%G in ('dir /b /s /a %*') do (
set relpath=%%G
set relpath=!relpath:*%~dp0=!
call :add-to-list !relpath!
Expand All @@ -446,8 +450,7 @@ test\gc\binding.cc tools\icu\*.cc tools\icu\*.h') do (
set cppfilelist=%localcppfilelist%
)
call :run-python tools/cpplint.py %cppfilelist%
call :run-python tools/check-imports.py
goto jslint
goto exit

:add-to-list
echo %1 | findstr /c:"src\node_root_certs.h"
Expand Down