doc: explanation for browser support of HTTP/2 #14670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since browser support HTTP/2 only using SSL, the basic example given in the docs won't work if the client is a browser. Added a note to documentation explaining this and how to change the code to make browser support it.
nodejs-github-bot
added
doc
|
Provided by the friendly #goodnesssquad |
|
@jasnell discovered when reading the test. |
benjamingr
approved these changes
Aug 7, 2017
mscdex
reviewed
Aug 7, 2017
doc/api/http2.md
Outdated
| @@ -39,6 +39,12 @@ server.on('stream', (stream, headers) => { | |||
| server.listen(80); | |||
| ``` | |||
|
|
|||
| Note that this is an HTTP server and does not support HTTPS. | |||
There was a problem hiding this comment.
s/this/the above example/
Also, I think using the terms HTTP and HTTPS could be confusing since I would bet most people would associate those terms with HTTP 1.x?
There was a problem hiding this comment.
+1 ... s/HTTP server/HTTP2 server
There was a problem hiding this comment.
Or perhaps better yet: 'HTTP/2 server', which is used elsewhere in this document.
jasnell
approved these changes
Aug 8, 2017
addaleax
approved these changes
Aug 10, 2017
|
Landed in 52a0d97, and cut the subject line a bit to fit into 50 characters. Thank you a lot! |
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
Since browser support HTTP/2 only using SSL, the basic example given in the docs won't work if the client is a browser. Added a note to documentation explaining this and how to change the code to make browser support it. PR-URL: #14670 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 13, 2017
Since browser support HTTP/2 only using SSL, the basic example given in the docs won't work if the client is a browser. Added a note to documentation explaining this and how to change the code to make browser support it. PR-URL: nodejs#14670 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 14, 2017
Since browser support HTTP/2 only using SSL, the basic example given in the docs won't work if the client is a browser. Added a note to documentation explaining this and how to change the code to make browser support it. PR-URL: #14670 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since browsers support HTTP/2 only using SSL, the basic example
given in the docs won't work if the client is a browser.
Added a note in
http2documentation explaining this and how to changethe code to make browser support it.
Checklist
Affected core subsystem(s)